Browse Source

Polish RequestRejectedHandler

Issue gh-5007
Rob Winch 5 years ago
parent
commit
0483b3e042

+ 1 - 1
web/src/main/java/org/springframework/security/web/FilterChainProxy.java

@@ -183,7 +183,7 @@ public class FilterChainProxy extends GenericFilterBean {
 				request.setAttribute(FILTER_APPLIED, Boolean.TRUE);
 				doFilterInternal(request, response, chain);
 			} catch (RequestRejectedException e) {
-				requestRejectedHandler.handle((HttpServletRequest) request, (HttpServletResponse) response, e);
+				this.requestRejectedHandler.handle((HttpServletRequest) request, (HttpServletResponse) response, e);
 			}
 			finally {
 				SecurityContextHolder.clearContext();

+ 2 - 2
web/src/main/java/org/springframework/security/web/firewall/DefaultRequestRejectedHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,7 +25,7 @@ import javax.servlet.http.HttpServletResponse;
  * Default implementation of {@link RequestRejectedHandler} that simply rethrows the exception.
  *
  * @author Leonard Brünings
- * @since 5.2
+ * @since 5.4
  */
 public class DefaultRequestRejectedHandler implements RequestRejectedHandler {
 	@Override

+ 2 - 2
web/src/main/java/org/springframework/security/web/firewall/HttpStatusRequestRejectedHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@ import org.apache.commons.logging.LogFactory;
  * A simple implementation of {@link RequestRejectedHandler} that sends an error with configurable status code.
  *
  * @author Leonard Brünings
- * @since 5.2
+ * @since 5.4
  */
 public class HttpStatusRequestRejectedHandler implements RequestRejectedHandler {
 	private static final Log logger = LogFactory.getLog(HttpStatusRequestRejectedHandler.class);

+ 2 - 2
web/src/main/java/org/springframework/security/web/firewall/RequestRejectedHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -26,7 +26,7 @@ import javax.servlet.http.HttpServletResponse;
  * <code>RequestRejectedException</code>.
  *
  * @author Leonard Brünings
- * @since 5.2
+ * @since 5.4
  */
 public interface RequestRejectedHandler {
 	// ~ Methods

+ 2 - 2
web/src/test/java/org/springframework/security/web/firewall/DefaultRequestRejectedHandlerTest.java → web/src/test/java/org/springframework/security/web/firewall/DefaultRequestRejectedHandlerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,7 +25,7 @@ import org.hamcrest.CoreMatchers;
 import org.junit.Assert;
 import org.junit.Test;
 
-public class DefaultRequestRejectedHandlerTest {
+public class DefaultRequestRejectedHandlerTests {
 
 	@Test
 	public void defaultRequestRejectedHandlerRethrowsTheException() throws Exception {

+ 2 - 2
web/src/test/java/org/springframework/security/web/firewall/HttpStatusRequestRejectedHandlerTest.java → web/src/test/java/org/springframework/security/web/firewall/HttpStatusRequestRejectedHandlerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,7 +24,7 @@ import javax.servlet.http.HttpServletResponse;
 
 import org.junit.Test;
 
-public class HttpStatusRequestRejectedHandlerTest {
+public class HttpStatusRequestRejectedHandlerTests {
 
 	@Test
 	public void httpStatusRequestRejectedHandlerUsesStatus400byDefault() throws Exception {