Sfoglia il codice sorgente

SEC-561: Removed setting of respose buffer size prior to redirect.

Luke Taylor 18 anni fa
parent
commit
2ef2bfc514

+ 1 - 18
core/src/main/java/org/acegisecurity/ui/AbstractProcessingFilter.java

@@ -193,15 +193,6 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
 	 */
 	private boolean continueChainBeforeSuccessfulAuthentication = false;
 
-	/**
-	 * Specifies the buffer size to use in the event of a directory. A buffer
-	 * size is used to ensure the response is not written back to the client
-	 * immediately. This provides a way for the <code>HttpSession</code> to be
-	 * updated before the browser redirect will be sent. Defaults to an 8 Kb
-	 * buffer.
-	 */
-	private int bufferSize = 8 * 1024;
-
 	/**
 	 * If true, causes any redirection URLs to be calculated minus the protocol
 	 * and context path (defaults to false).
@@ -357,8 +348,7 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
 	}
 
 	public static String obtainFullRequestUrl(HttpServletRequest request) {
-		SavedRequest savedRequest = (SavedRequest) request.getSession().getAttribute(
-				AbstractProcessingFilter.ACEGI_SAVED_REQUEST_KEY);
+		SavedRequest savedRequest = (SavedRequest) request.getSession().getAttribute(ACEGI_SAVED_REQUEST_KEY);
 
 		return (savedRequest == null) ? null : savedRequest.getFullRequestUrl();
 	}
@@ -438,9 +428,6 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
 			finalUrl = url;
 		}
 
-		Assert.isTrue(!response.isCommitted(),
-				"Response already committed; the authentication mechanism must be able to modify buffer size");
-		response.setBufferSize(bufferSize);
 		response.sendRedirect(response.encodeRedirectURL(finalUrl));
 	}
 
@@ -630,10 +617,6 @@ public abstract class AbstractProcessingFilter implements Filter, InitializingBe
 		return authenticationDetailsSource;
 	}
 
-	public void setBufferSize(int bufferSize) {
-		this.bufferSize = bufferSize;
-	}
-
 	public void setUseRelativeContext(boolean useRelativeContext) {
 		this.useRelativeContext = useRelativeContext;
 	}