|
@@ -1,5 +1,5 @@
|
|
|
/*
|
|
|
- * Copyright 2002-2023 the original author or authors.
|
|
|
+ * Copyright 2002-2025 the original author or authors.
|
|
|
*
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
* you may not use this file except in compliance with the License.
|
|
@@ -14,10 +14,11 @@
|
|
|
* limitations under the License.
|
|
|
*/
|
|
|
|
|
|
-package org.springframework.security.web.server.ui;
|
|
|
+package org.springframework.security.web;
|
|
|
|
|
|
import java.io.IOException;
|
|
|
|
|
|
+import org.assertj.core.api.ThrowingConsumer;
|
|
|
import org.junit.jupiter.api.BeforeEach;
|
|
|
import org.junit.jupiter.api.Test;
|
|
|
|
|
@@ -30,9 +31,11 @@ import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
|
|
|
|
|
|
import static org.assertj.core.api.Assertions.assertThat;
|
|
|
|
|
|
-public class FormRedirectStrategyTests {
|
|
|
+public class FormPostRedirectStrategyTests {
|
|
|
|
|
|
- private FormRedirectStrategy formRedirectStrategy;
|
|
|
+ private static final String POLICY_DIRECTIVE_PATTERN = "script-src 'nonce-(.+)'";
|
|
|
+
|
|
|
+ private FormPostRedirectStrategy redirectStrategy;
|
|
|
|
|
|
private MockHttpServletRequest request;
|
|
|
|
|
@@ -40,7 +43,7 @@ public class FormRedirectStrategyTests {
|
|
|
|
|
|
@BeforeEach
|
|
|
public void beforeEach() {
|
|
|
- this.formRedirectStrategy = new FormRedirectStrategy();
|
|
|
+ this.redirectStrategy = new FormPostRedirectStrategy();
|
|
|
final MockServletContext mockServletContext = new MockServletContext();
|
|
|
mockServletContext.setContextPath("/contextPath");
|
|
|
// the request URL doesn't matter
|
|
@@ -50,39 +53,43 @@ public class FormRedirectStrategyTests {
|
|
|
|
|
|
@Test
|
|
|
public void absoluteUrlNoParametersRedirect() throws IOException {
|
|
|
- this.formRedirectStrategy.sendRedirect(this.request, this.response, "https://example.com");
|
|
|
+ this.redirectStrategy.sendRedirect(this.request, this.response, "https://example.com");
|
|
|
assertThat(this.response.getStatus()).isEqualTo(HttpStatus.OK.value());
|
|
|
assertThat(this.response.getContentType()).isEqualTo(MediaType.TEXT_HTML_VALUE);
|
|
|
assertThat(this.response.getContentAsString()).contains("action=\"https://example.com\"");
|
|
|
+ assertThat(this.response).satisfies(hasScriptSrcNonce());
|
|
|
}
|
|
|
|
|
|
@Test
|
|
|
public void rootRelativeUrlNoParametersRedirect() throws IOException {
|
|
|
- this.formRedirectStrategy.sendRedirect(this.request, this.response, "/test");
|
|
|
+ this.redirectStrategy.sendRedirect(this.request, this.response, "/test");
|
|
|
assertThat(this.response.getStatus()).isEqualTo(HttpStatus.OK.value());
|
|
|
assertThat(this.response.getContentType()).isEqualTo(MediaType.TEXT_HTML_VALUE);
|
|
|
assertThat(this.response.getContentAsString()).contains("action=\"/test\"");
|
|
|
+ assertThat(this.response).satisfies(hasScriptSrcNonce());
|
|
|
}
|
|
|
|
|
|
@Test
|
|
|
public void relativeUrlNoParametersRedirect() throws IOException {
|
|
|
- this.formRedirectStrategy.sendRedirect(this.request, this.response, "test");
|
|
|
+ this.redirectStrategy.sendRedirect(this.request, this.response, "test");
|
|
|
assertThat(this.response.getStatus()).isEqualTo(HttpStatus.OK.value());
|
|
|
assertThat(this.response.getContentType()).isEqualTo(MediaType.TEXT_HTML_VALUE);
|
|
|
assertThat(this.response.getContentAsString()).contains("action=\"test\"");
|
|
|
+ assertThat(this.response).satisfies(hasScriptSrcNonce());
|
|
|
}
|
|
|
|
|
|
@Test
|
|
|
public void absoluteUrlWithFragmentRedirect() throws IOException {
|
|
|
- this.formRedirectStrategy.sendRedirect(this.request, this.response, "https://example.com/path#fragment");
|
|
|
+ this.redirectStrategy.sendRedirect(this.request, this.response, "https://example.com/path#fragment");
|
|
|
assertThat(this.response.getStatus()).isEqualTo(HttpStatus.OK.value());
|
|
|
assertThat(this.response.getContentType()).isEqualTo(MediaType.TEXT_HTML_VALUE);
|
|
|
assertThat(this.response.getContentAsString()).contains("action=\"https://example.com/path#fragment\"");
|
|
|
+ assertThat(this.response).satisfies(hasScriptSrcNonce());
|
|
|
}
|
|
|
|
|
|
@Test
|
|
|
public void absoluteUrlWithQueryParamsRedirect() throws IOException {
|
|
|
- this.formRedirectStrategy.sendRedirect(this.request, this.response,
|
|
|
+ this.redirectStrategy.sendRedirect(this.request, this.response,
|
|
|
"https://example.com/path?param1=one¶m2=two#fragment");
|
|
|
assertThat(this.response.getStatus()).isEqualTo(HttpStatus.OK.value());
|
|
|
assertThat(this.response.getContentType()).isEqualTo(MediaType.TEXT_HTML_VALUE);
|
|
@@ -91,6 +98,18 @@ public class FormRedirectStrategyTests {
|
|
|
.contains("<input name=\"param1\" type=\"hidden\" value=\"one\" />");
|
|
|
assertThat(this.response.getContentAsString())
|
|
|
.contains("<input name=\"param2\" type=\"hidden\" value=\"two\" />");
|
|
|
+ assertThat(this.response).satisfies(hasScriptSrcNonce());
|
|
|
+ }
|
|
|
+
|
|
|
+ private ThrowingConsumer<MockHttpServletResponse> hasScriptSrcNonce() {
|
|
|
+ return (response) -> {
|
|
|
+ final String policyDirective = response.getHeader("Content-Security-Policy");
|
|
|
+ assertThat(policyDirective).isNotEmpty();
|
|
|
+ assertThat(policyDirective).matches(POLICY_DIRECTIVE_PATTERN);
|
|
|
+
|
|
|
+ final String nonce = policyDirective.replaceFirst(POLICY_DIRECTIVE_PATTERN, "$1");
|
|
|
+ assertThat(response.getContentAsString()).contains("<script nonce=\"%s\">".formatted(nonce));
|
|
|
+ };
|
|
|
}
|
|
|
|
|
|
}
|