浏览代码

Revert "SEC-2045: AbstractPreAuthenticationFilter afterPropertiesSet invokes super"

This commit contains the wrong JIRA ID.

This reverts commit c53fd99430739ced5289c6bbe5c50563710fa610.
Rob Winch 13 年之前
父节点
当前提交
5945abb10a

+ 0 - 6
web/src/main/java/org/springframework/security/web/authentication/preauth/AbstractPreAuthenticatedProcessingFilter.java

@@ -69,12 +69,6 @@ public abstract class AbstractPreAuthenticatedProcessingFilter extends GenericFi
      */
     @Override
     public void afterPropertiesSet() {
-        try {
-            super.afterPropertiesSet();
-        } catch(ServletException e) {
-            // convert to RuntimeException for passivity on afterPropertiesSet signature
-            throw new RuntimeException(e);
-        }
         Assert.notNull(authenticationManager, "An AuthenticationManager must be set");
     }
 

+ 0 - 17
web/src/test/java/org/springframework/security/web/authentication/preauth/AbstractPreAuthenticatedProcessingFilterTests.java

@@ -5,7 +5,6 @@ import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.*;
 
 import javax.servlet.FilterChain;
-import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
 
 import org.junit.After;
@@ -78,16 +77,6 @@ public class AbstractPreAuthenticatedProcessingFilterTests {
         }
     }
 
-    // SEC-2045
-    @Test
-    public void testAfterPropertiesSetInvokesSuper() throws Exception {
-        ConcretePreAuthenticatedProcessingFilter filter = new ConcretePreAuthenticatedProcessingFilter();
-        AuthenticationManager am = mock(AuthenticationManager.class);
-        filter.setAuthenticationManager(am);
-        filter.afterPropertiesSet();
-        assertTrue(filter.initFilterBeanInvoked);
-    }
-
     @Test
     public void testDoFilterAuthenticated() throws Exception {
         testDoFilter(true);
@@ -151,18 +140,12 @@ public class AbstractPreAuthenticatedProcessingFilterTests {
 
     private static class ConcretePreAuthenticatedProcessingFilter extends AbstractPreAuthenticatedProcessingFilter {
         private String principal = "testPrincipal";
-        private boolean initFilterBeanInvoked;
         protected Object getPreAuthenticatedPrincipal(HttpServletRequest httpRequest) {
             return principal;
         }
         protected Object getPreAuthenticatedCredentials(HttpServletRequest httpRequest) {
             return "testCredentials";
         }
-        @Override
-        protected void initFilterBean() throws ServletException {
-            super.initFilterBean();
-            initFilterBeanInvoked = true;
-        }
     }
 
 }