Browse Source

Unnecessary conversion to String

Lars Grefer 6 years ago
parent
commit
8d0ca14e55

+ 2 - 2
core/src/main/java/org/springframework/security/core/token/KeyBasedPersistenceTokenService.java

@@ -83,7 +83,7 @@ public class KeyBasedPersistenceTokenService implements TokenService, Initializi
 		long creationTime = new Date().getTime();
 		String serverSecret = computeServerSecretApplicableAt(creationTime);
 		String pseudoRandomNumber = generatePseudoRandomNumber();
-		String content = Long.toString(creationTime) + ":" + pseudoRandomNumber + ":"
+		String content = creationTime + ":" + pseudoRandomNumber + ":"
 				+ extendedInformation;
 
 		// Compute key
@@ -126,7 +126,7 @@ public class KeyBasedPersistenceTokenService implements TokenService, Initializi
 		String sha1Hex = tokens[tokens.length - 1];
 
 		// Verification
-		String content = Long.toString(creationTime) + ":" + pseudoRandomNumber + ":"
+		String content = creationTime + ":" + pseudoRandomNumber + ":"
 				+ extendedInfo.toString();
 		String expectedSha512Hex = Sha512DigestUtils.shaHex(content + ":" + serverSecret);
 		Assert.isTrue(expectedSha512Hex.equals(sha1Hex), "Key verification failure");

+ 1 - 1
itest/context/src/integration-test/java/org/springframework/security/performance/FilterChainPerformanceTests.java

@@ -127,7 +127,7 @@ public class FilterChainPerformanceTests {
 					HttpSessionSecurityContextRepository.SPRING_SECURITY_CONTEXT_KEY,
 					SecurityContextHolder.getContext());
 			SecurityContextHolder.clearContext();
-			sw.start(Integer.toString(nAuthorities) + " authorities");
+			sw.start(nAuthorities + " authorities");
 			runWithStack(minimalStack);
 			System.out.println(sw.shortSummary());
 			sw.stop();

+ 1 - 1
web/src/main/java/org/springframework/security/web/util/RedirectUrlBuilder.java

@@ -75,7 +75,7 @@ public class RedirectUrlBuilder {
 
 		// Append the port number if it's not standard for the scheme
 		if (port != (scheme.equals("http") ? 80 : 443)) {
-			sb.append(":").append(Integer.toString(port));
+			sb.append(":").append(port);
 		}
 
 		if (contextPath != null) {