Trang chủ Khám phá Trợ giúp
Đăng ký Đăng nhập
github
/
spring-security
mirror of https://github.com/spring-projects/spring-security
2
0
Fork 0
Các tập tin Các vấn đề 0 Wiki
Browse Source

Use function definition instead of arrow function expression

Closes gh-13106
Marcus Da Coregio 2 năm trước cách đây
mục cha
e9a02bc6e9
commit
8d5304f530
6 tập tin đã thay đổi với 18 bổ sung và 18 xóa
Split View Hiển thị tình trạng sai khác
  1. 3 3
      saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/Saml2WebSsoAuthenticationRequestFilter.java
  2. 3 3
      saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2LogoutRequestFilter.java
  3. 3 3
      saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2RelyingPartyInitiatedLogoutSuccessHandler.java
  4. 3 3
      saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/Saml2WebSsoAuthenticationRequestFilterTests.java
  5. 3 3
      saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2LogoutRequestFilterTests.java
  6. 3 3
      saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2RelyingPartyInitiatedLogoutSuccessHandlerTests.java

+ 3 - 3
saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/Saml2WebSsoAuthenticationRequestFilter.java
Xem Tập Tin 

@@ -1,5 +1,5 @@
 
 /*
 
- * Copyright 2002-2022 the original author or authors.
 
+ * Copyright 2002-2023 the original author or authors.
 
  *
 
  * Licensed under the Apache License, Version 2.0 (the "License");
 
  * you may not use this file except in compliance with the License.
 
@@ -231,7 +231,7 @@ public class Saml2WebSsoAuthenticationRequestFilter extends OncePerRequestFilter
 
 		html.append("<!DOCTYPE html>\n");
 
 		html.append("<html>\n").append("    <head>\n");
 
 		html.append("        <meta http-equiv=\"Content-Security-Policy\" ")
 
-				.append("content=\"script-src 'sha256-t+jmhLjs1ocvgaHBJsFcgznRk68d37TLtbI3NE9h7EU='\">\n");
 
+				.append("content=\"script-src 'sha256-oZhLbc2kO8b8oaYLrUc7uye1MgVKMyLtPqWR4WtKF+c='\">\n");
 
 		html.append("        <meta charset=\"utf-8\" />\n");
 
 		html.append("    </head>\n");
 
 		html.append("    <body>\n");
 
@@ -262,7 +262,7 @@ public class Saml2WebSsoAuthenticationRequestFilter extends OncePerRequestFilter
 
 		html.append("            </noscript>\n");
 
 		html.append("        </form>\n");
 
 		html.append("        \n");
 
-		html.append("        <script>window.onload = () => document.forms[0].submit();</script>\n");
 
+		html.append("        <script>window.onload = function() { document.forms[0].submit(); }</script>\n");
 
 		html.append("    </body>\n");
 
 		html.append("</html>");
 
 		return html.toString();

+ 3 - 3
saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2LogoutRequestFilter.java
Xem Tập Tin 

@@ -1,5 +1,5 @@
 
 /*
 
- * Copyright 2002-2022 the original author or authors.
 
+ * Copyright 2002-2023 the original author or authors.
 
  *
 
  * Licensed under the Apache License, Version 2.0 (the "License");
 
  * you may not use this file except in compliance with the License.
 
@@ -216,7 +216,7 @@ public final class Saml2LogoutRequestFilter extends OncePerRequestFilter {
 
 		html.append("<!DOCTYPE html>\n");
 
 		html.append("<html>\n").append("    <head>\n");
 
 		html.append("        <meta http-equiv=\"Content-Security-Policy\" ")
 
-				.append("content=\"script-src 'sha256-t+jmhLjs1ocvgaHBJsFcgznRk68d37TLtbI3NE9h7EU='\">\n");
 
+				.append("content=\"script-src 'sha256-oZhLbc2kO8b8oaYLrUc7uye1MgVKMyLtPqWR4WtKF+c='\">\n");
 
 		html.append("        <meta charset=\"utf-8\" />\n");
 
 		html.append("    </head>\n");
 
 		html.append("    <body>\n");
 
@@ -247,7 +247,7 @@ public final class Saml2LogoutRequestFilter extends OncePerRequestFilter {
 
 		html.append("            </noscript>\n");
 
 		html.append("        </form>\n");
 
 		html.append("        \n");
 
-		html.append("        <script>window.onload = () => document.forms[0].submit();</script>\n");
 
+		html.append("        <script>window.onload = function() { document.forms[0].submit(); }</script>\n");
 
 		html.append("    </body>\n");
 
 		html.append("</html>");
 
 		return html.toString();

+ 3 - 3
saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2RelyingPartyInitiatedLogoutSuccessHandler.java
Xem Tập Tin 

@@ -1,5 +1,5 @@
 
 /*
 
- * Copyright 2002-2022 the original author or authors.
 
+ * Copyright 2002-2023 the original author or authors.
 
  *
 
  * Licensed under the Apache License, Version 2.0 (the "License");
 
  * you may not use this file except in compliance with the License.
 
@@ -120,7 +120,7 @@ public final class Saml2RelyingPartyInitiatedLogoutSuccessHandler implements Log
 
 		html.append("<!DOCTYPE html>\n");
 
 		html.append("<html>\n").append("    <head>\n");
 
 		html.append("        <meta http-equiv=\"Content-Security-Policy\" ")
 
-				.append("content=\"script-src 'sha256-t+jmhLjs1ocvgaHBJsFcgznRk68d37TLtbI3NE9h7EU='\">\n");
 
+				.append("content=\"script-src 'sha256-oZhLbc2kO8b8oaYLrUc7uye1MgVKMyLtPqWR4WtKF+c='\">\n");
 
 		html.append("        <meta charset=\"utf-8\" />\n");
 
 		html.append("    </head>\n");
 
 		html.append("    <body>\n");
 
@@ -151,7 +151,7 @@ public final class Saml2RelyingPartyInitiatedLogoutSuccessHandler implements Log
 
 		html.append("            </noscript>\n");
 
 		html.append("        </form>\n");
 
 		html.append("        \n");
 
-		html.append("        <script>window.onload = () => document.forms[0].submit();</script>\n");
 
+		html.append("        <script>window.onload = function() { document.forms[0].submit(); }</script>\n");
 
 		html.append("    </body>\n");
 
 		html.append("</html>");
 
 		return html.toString();

+ 3 - 3
saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/Saml2WebSsoAuthenticationRequestFilterTests.java
Xem Tập Tin 

@@ -1,5 +1,5 @@
 
 /*
 
- * Copyright 2002-2022 the original author or authors.
 
+ * Copyright 2002-2023 the original author or authors.
 
  *
 
  * Licensed under the Apache License, Version 2.0 (the "License");
 
  * you may not use this file except in compliance with the License.
 
@@ -194,8 +194,8 @@ public class Saml2WebSsoAuthenticationRequestFilterTests {
 
 		this.filter.doFilterInternal(this.request, this.response, this.filterChain);
 
 		assertThat(this.response.getHeader("Location")).isNull();
 
 		assertThat(this.response.getContentAsString()).contains(
 
-				"<meta http-equiv=\"Content-Security-Policy\" content=\"script-src 'sha256-t+jmhLjs1ocvgaHBJsFcgznRk68d37TLtbI3NE9h7EU='\">")
 
-				.contains("<script>window.onload = () => document.forms[0].submit();</script>")
 
+				"<meta http-equiv=\"Content-Security-Policy\" content=\"script-src 'sha256-oZhLbc2kO8b8oaYLrUc7uye1MgVKMyLtPqWR4WtKF+c='\">")
 
+				.contains("<script>window.onload = function() { document.forms[0].submit(); }</script>")
 
 				.contains("<form action=\"https://sso-url.example.com/IDP/SSO\" method=\"post\">")
 
 				.contains("<input type=\"hidden\" name=\"SAMLRequest\"")
 
 				.contains("value=\"" + relayStateEncoded + "\"");

+ 3 - 3
saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2LogoutRequestFilterTests.java
Xem Tập Tin 

@@ -1,5 +1,5 @@
 
 /*
 
- * Copyright 2002-2022 the original author or authors.
 
+ * Copyright 2002-2023 the original author or authors.
 
  *
 
  * Licensed under the Apache License, Version 2.0 (the "License");
 
  * you may not use this file except in compliance with the License.
 
@@ -118,8 +118,8 @@ public class Saml2LogoutRequestFilterTests {
 
 		assertThat(content).contains(Saml2ParameterNames.SAML_RESPONSE);
 
 		assertThat(content).contains(registration.getAssertingPartyDetails().getSingleLogoutServiceResponseLocation());
 
 		assertThat(content).contains(
 
-				"<meta http-equiv=\"Content-Security-Policy\" content=\"script-src 'sha256-t+jmhLjs1ocvgaHBJsFcgznRk68d37TLtbI3NE9h7EU='\">");
 
-		assertThat(content).contains("<script>window.onload = () => document.forms[0].submit();</script>");
 
+				"<meta http-equiv=\"Content-Security-Policy\" content=\"script-src 'sha256-oZhLbc2kO8b8oaYLrUc7uye1MgVKMyLtPqWR4WtKF+c='\">");
 
+		assertThat(content).contains("<script>window.onload = function() { document.forms[0].submit(); }</script>");
 
 		verify(this.securityContextHolderStrategy).getContext();
 
 	}

+ 3 - 3
saml2/saml2-service-provider/src/test/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2RelyingPartyInitiatedLogoutSuccessHandlerTests.java
Xem Tập Tin 

@@ -1,5 +1,5 @@
 
 /*
 
- * Copyright 2002-2022 the original author or authors.
 
+ * Copyright 2002-2023 the original author or authors.
 
  *
 
  * Licensed under the Apache License, Version 2.0 (the "License");
 
  * you may not use this file except in compliance with the License.
 
@@ -98,8 +98,8 @@ public class Saml2RelyingPartyInitiatedLogoutSuccessHandlerTests {
 
 		assertThat(content).contains(Saml2ParameterNames.SAML_REQUEST);
 
 		assertThat(content).contains(registration.getAssertingPartyDetails().getSingleLogoutServiceLocation());
 
 		assertThat(content).contains(
 
-				"<meta http-equiv=\"Content-Security-Policy\" content=\"script-src 'sha256-t+jmhLjs1ocvgaHBJsFcgznRk68d37TLtbI3NE9h7EU='\">");
 
-		assertThat(content).contains("<script>window.onload = () => document.forms[0].submit();</script>");
 
+				"<meta http-equiv=\"Content-Security-Policy\" content=\"script-src 'sha256-oZhLbc2kO8b8oaYLrUc7uye1MgVKMyLtPqWR4WtKF+c='\">");
 
+		assertThat(content).contains("<script>window.onload = function() { document.forms[0].submit(); }</script>");
 
 	}
 
 
 	private Saml2Authentication authentication(RelyingPartyRegistration registration) {