Ver código fonte

Refactoring to remove warnings in LDAP module.

Luke Taylor 16 anos atrás
pai
commit
929b6bb1a0

+ 6 - 2
ldap/src/main/java/org/springframework/security/ldap/authentication/LdapAuthenticationProvider.java

@@ -50,7 +50,7 @@ import org.apache.commons.logging.LogFactory;
  * against an LDAP server.
  * <p>
  * There are many ways in which an LDAP directory can be configured so this class delegates most of
- * its responsibilites to two separate strategy interfaces, {@link LdapAuthenticator}
+ * its responsibilities to two separate strategy interfaces, {@link LdapAuthenticator}
  * and {@link LdapAuthoritiesPopulator}.
  *
  * <h3>LdapAuthenticator</h3>
@@ -237,13 +237,17 @@ public class LdapAuthenticationProvider implements AuthenticationProvider, Messa
         final UsernamePasswordAuthenticationToken userToken = (UsernamePasswordAuthenticationToken)authentication;
 
         String username = userToken.getName();
+        String password = (String) authentication.getCredentials();
+
+        if (logger.isDebugEnabled()) {
+            logger.debug("Processing authentication request for user: " + username);
+        }
 
         if (!StringUtils.hasLength(username)) {
             throw new BadCredentialsException(messages.getMessage("LdapAuthenticationProvider.emptyUsername",
                     "Empty Username"));
         }
 
-        String password = (String) authentication.getCredentials();
         Assert.notNull(password, "Null password was supplied in authentication token");
 
         try {

+ 1 - 0
ldap/src/test/java/org/springframework/security/ldap/AbstractLdapIntegrationTests.java

@@ -56,6 +56,7 @@ public abstract class AbstractLdapIntegrationTests {
     protected AbstractLdapIntegrationTests() {
     }
 
+    @SuppressWarnings("unchecked")
     @BeforeClass
     public static void startServer() throws Exception {
         shutdownRunningServers();