소스 검색

Polish PasswordEncoderUtilsTests

* Add more tests
* Smaller tests
* Follow new naming convention
Rob Winch 9 년 전
부모
커밋
dc9f9b140f
1개의 변경된 파일19개의 추가작업 그리고 4개의 파일을 삭제
  1. 19 4
      core/src/test/java/org/springframework/security/authentication/encoding/PasswordEncoderUtilsTests.java

+ 19 - 4
core/src/test/java/org/springframework/security/authentication/encoding/PasswordEncoderUtilsTests.java

@@ -25,25 +25,40 @@ import org.junit.Test;
 public class PasswordEncoderUtilsTests {
 
 	@Test
-	public void differentLength() {
+	public void equalsWhenDifferentLengthThenFalse() {
 		assertThat(PasswordEncoderUtils.equals("abc", "a")).isFalse();
 		assertThat(PasswordEncoderUtils.equals("a", "abc")).isFalse();
 	}
 
 	@Test
-	public void equalsNull() {
+	public void equalsWhenNullAndNotEmtpyThenFalse() {
 		assertThat(PasswordEncoderUtils.equals(null, "a")).isFalse();
 		assertThat(PasswordEncoderUtils.equals("a", null)).isFalse();
+	}
+
+	@Test
+	public void equalsWhenNullAndNullThenTrue() {
 		assertThat(PasswordEncoderUtils.equals(null, null)).isTrue();
 	}
 
 	@Test
-	public void equalsCaseSensitive() {
+	public void equalsWhenNullAndEmptyThenFalse() {
+		assertThat(PasswordEncoderUtils.equals(null, "")).isFalse();
+		assertThat(PasswordEncoderUtils.equals("", null)).isFalse();
+	}
+
+	@Test
+	public void equalsWhenEmtpyAndEmptyThenTrue() {
+		assertThat(PasswordEncoderUtils.equals("", "")).isTrue();
+	}
+
+	@Test
+	public void equalsWhenDifferentCaseThenFalse() {
 		assertThat(PasswordEncoderUtils.equals("aBc", "abc")).isFalse();
 	}
 
 	@Test
-	public void equalsSuccess() {
+	public void equalsWhenSameThenTrue() {
 		assertThat(PasswordEncoderUtils.equals("abcdef", "abcdef")).isTrue();
 	}
 }