浏览代码

Add Test

Issue gh-13660
Josh Cummings 1 年之前
父节点
当前提交
ed6ff670d1

+ 1 - 1
web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java

@@ -141,7 +141,7 @@ public final class ObservationFilterChainDecorator implements FilterChainProxy.F
 
 	static final class ObservationFilter implements Filter {
 
-		private static final Map<String, String> OBSERVATION_NAMES = new HashMap<>();
+		static final Map<String, String> OBSERVATION_NAMES = new HashMap<>();
 
 		static {
 			OBSERVATION_NAMES.put("DisableEncodeUrlFilter", "session.urlencoding");

+ 7 - 0
web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java

@@ -150,6 +150,13 @@ public class ObservationFilterChainDecoratorTests {
 			.isEqualTo(expectedFilterNameTag);
 	}
 
+	// gh-13660
+	@Test
+	void observationNamesDoNotContainDashes() {
+		ObservationFilterChainDecorator.ObservationFilter.OBSERVATION_NAMES.values()
+			.forEach((name) -> assertThat(name).doesNotContain("-"));
+	}
+
 	static Stream<Arguments> decorateFiltersWhenCompletesThenHasSpringSecurityReachedFilterNameTag() {
 		Filter filterWithName = new BasicAuthenticationFilter();