Jelajahi Sumber

remove redundant modifiers found by checkstyle

Lars Grefer 6 tahun lalu
induk
melakukan
ff1070df36
100 mengubah file dengan 154 tambahan dan 157 penghapusan
  1. 2 2
      acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java
  2. 2 2
      acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java
  3. 2 2
      cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java
  4. 2 2
      cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java
  5. 1 1
      cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java
  6. 2 2
      cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java
  7. 1 1
      cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java
  8. 1 1
      config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java
  9. 2 2
      config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java
  10. 1 1
      config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java
  11. 1 1
      config/src/main/java/org/springframework/security/config/annotation/configuration/AutowireBeanFactoryObjectPostProcessor.java
  12. 1 1
      config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecuritySelector.java
  13. 1 1
      config/src/main/java/org/springframework/security/config/annotation/web/configuration/AutowiredWebSecurityConfigurersIgnoreParents.java
  14. 2 2
      config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java
  15. 1 1
      config/src/main/java/org/springframework/security/config/annotation/web/configurers/UrlAuthorizationConfigurer.java
  16. 1 1
      config/src/main/java/org/springframework/security/config/crypto/RsaKeyConversionServicePostProcessor.java
  17. 1 1
      config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java
  18. 1 1
      config/src/main/java/org/springframework/security/config/http/HttpConfigurationBuilder.java
  19. 2 2
      config/src/main/java/org/springframework/security/config/http/HttpSecurityBeanDefinitionParser.java
  20. 1 1
      config/src/main/java/org/springframework/security/config/http/LogoutBeanDefinitionParser.java
  21. 1 1
      config/src/main/java/org/springframework/security/config/method/ProtectPointcutPostProcessor.java
  22. 1 1
      config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java
  23. 1 2
      config/src/main/java/org/springframework/security/config/websocket/WebSocketMessageBrokerSecurityBeanDefinitionParser.java
  24. 1 1
      config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java
  25. 1 1
      config/src/test/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurerTests.java
  26. 1 1
      config/src/test/java/org/springframework/security/config/annotation/web/configurers/NamespaceHttpExpressionHandlerTests.java
  27. 1 1
      config/src/test/java/org/springframework/security/config/annotation/web/configurers/SecurityContextConfigurerTests.java
  28. 2 2
      config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java
  29. 1 1
      config/src/test/java/org/springframework/security/config/http/CsrfConfigTests.java
  30. 1 1
      config/src/test/java/org/springframework/security/config/http/HttpConfigTests.java
  31. 1 1
      config/src/test/java/org/springframework/security/config/http/MiscHttpConfigTests.java
  32. 1 1
      config/src/test/java/org/springframework/security/config/http/SessionManagementConfigTests.java
  33. 1 1
      config/src/test/java/org/springframework/security/htmlunit/server/HtmlUnitWebTestClient.java
  34. 1 1
      config/src/test/java/org/springframework/security/htmlunit/server/MockWebResponseBuilder.java
  35. 2 2
      core/src/main/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContext.java
  36. 1 1
      core/src/main/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java
  37. 1 1
      core/src/main/java/org/springframework/security/access/method/MapBasedMethodSecurityMetadataSource.java
  38. 1 1
      core/src/main/java/org/springframework/security/authentication/jaas/AbstractJaasAuthenticationProvider.java
  39. 5 5
      core/src/main/java/org/springframework/security/concurrent/DelegatingSecurityContextScheduledExecutorService.java
  40. 3 3
      core/src/main/java/org/springframework/security/core/ComparableVersion.java
  41. 1 1
      core/src/main/java/org/springframework/security/jackson2/AnonymousAuthenticationTokenMixin.java
  42. 1 1
      core/src/main/java/org/springframework/security/jackson2/RememberMeAuthenticationTokenMixin.java
  43. 1 1
      core/src/main/java/org/springframework/security/jackson2/SecurityJackson2Modules.java
  44. 1 1
      core/src/main/java/org/springframework/security/provisioning/MutableUser.java
  45. 1 1
      core/src/test/java/org/springframework/security/access/SecurityConfigTests.java
  46. 10 10
      core/src/test/java/org/springframework/security/access/annotation/BusinessService.java
  47. 5 5
      core/src/test/java/org/springframework/security/access/annotation/SecuredAnnotationSecurityMetadataSourceTests.java
  48. 1 1
      core/src/test/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContextTests.java
  49. 8 8
      core/src/test/java/org/springframework/security/access/expression/method/PrePostAnnotationSecurityMetadataSourceTests.java
  50. 1 2
      core/src/test/java/org/springframework/security/access/intercept/AfterInvocationProviderManagerTests.java
  51. 1 2
      core/src/test/java/org/springframework/security/authentication/AbstractAuthenticationTokenTests.java
  52. 1 1
      core/src/test/java/org/springframework/security/authentication/DefaultAuthenticationEventPublisherTests.java
  53. 1 1
      core/src/test/java/org/springframework/security/authentication/jaas/JaasAuthenticationProviderTests.java
  54. 1 1
      core/src/test/java/org/springframework/security/authentication/rcp/RemoteAuthenticationProviderTests.java
  55. 2 2
      core/src/test/java/org/springframework/security/concurrent/DelegatingSecurityContextSupportTests.java
  56. 2 2
      core/src/test/java/org/springframework/security/core/parameters/AnnotationParameterNameDiscovererTests.java
  57. 1 1
      crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java
  58. 1 1
      crypto/src/main/java/org/springframework/security/crypto/encrypt/HexEncodingTextEncryptor.java
  59. 1 1
      crypto/src/main/java/org/springframework/security/crypto/keygen/HexEncodingStringKeyGenerator.java
  60. 2 2
      crypto/src/main/java/org/springframework/security/crypto/keygen/SecureRandomBytesKeyGenerator.java
  61. 2 2
      crypto/src/main/java/org/springframework/security/crypto/keygen/SharedKeyGenerator.java
  62. 2 2
      crypto/src/main/java/org/springframework/security/crypto/password/Digester.java
  63. 1 1
      crypto/src/test/java/org/springframework/security/crypto/encrypt/BouncyCastleAesBytesEncryptorEquivalencyTest.java
  64. 1 1
      ldap/src/integration-test/java/org/springframework/security/ldap/DefaultSpringSecurityContextSourceTests.java
  65. 1 1
      ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java
  66. 1 1
      ldap/src/test/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java
  67. 1 1
      messaging/src/main/java/org/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java
  68. 2 2
      messaging/src/main/java/org/springframework/security/messaging/util/matcher/AbstractMessageMatcherComposite.java
  69. 1 1
      messaging/src/test/java/org/springframework/security/messaging/context/AuthenticationPrincipalArgumentResolverTests.java
  70. 3 3
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenDecoderFactory.java
  71. 1 1
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenValidator.java
  72. 3 3
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java
  73. 1 1
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/AuthenticatedPrincipalOAuth2AuthorizedClientRepository.java
  74. 1 1
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java
  75. 2 2
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/function/client/OAuth2AuthorizedClientResolver.java
  76. 2 2
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/result/method/annotation/OAuth2AuthorizedClientResolver.java
  77. 1 1
      oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/server/AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository.java
  78. 2 2
      oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoderJwkSupport.java
  79. 1 1
      oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationEntryPoint.java
  80. 3 3
      oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationFilter.java
  81. 1 1
      oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandler.java
  82. 1 1
      oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandlerTests.java
  83. 1 1
      oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/server/BearerTokenServerAccessDeniedHandlerTests.java
  84. 1 1
      remoting/src/test/java/org/springframework/security/remoting/httpinvoker/AuthenticationSimpleHttpInvokerRequestExecutorTests.java
  85. 2 2
      samples/boot/oauth2authorizationserver/src/main/java/sample/AuthorizationServerConfiguration.java
  86. 1 1
      samples/boot/oauth2resourceserver-jwe/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java
  87. 1 1
      samples/boot/oauth2resourceserver-multitenancy/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java
  88. 1 1
      samples/boot/oauth2resourceserver-opaque/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java
  89. 1 1
      samples/boot/oauth2resourceserver-static/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java
  90. 1 1
      samples/boot/oauth2resourceserver/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java
  91. 1 1
      samples/xml/jaas/src/main/java/samples/jaas/UsernameEqualsPasswordLoginModule.java
  92. 1 1
      test/src/main/java/org/springframework/security/test/context/support/DelegatingTestExecutionListener.java
  93. 1 1
      test/src/main/java/org/springframework/security/test/context/support/WithUserDetailsSecurityContextFactory.java
  94. 1 1
      test/src/main/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessors.java
  95. 1 1
      test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsCsrfTests.java
  96. 1 1
      web/src/main/java/org/springframework/security/web/FilterInvocation.java
  97. 1 1
      web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java
  98. 2 2
      web/src/main/java/org/springframework/security/web/access/expression/ExpressionBasedFilterInvocationSecurityMetadataSource.java
  99. 1 1
      web/src/main/java/org/springframework/security/web/access/expression/WebExpressionConfigAttribute.java
  100. 2 2
      web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/DefaultWASUsernameAndGroupsExtractor.java

+ 2 - 2
acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java

@@ -41,14 +41,14 @@ class AclClassIdUtils {
 
 	private ConversionService conversionService;
 
-	public AclClassIdUtils() {
+	AclClassIdUtils() {
 		GenericConversionService genericConversionService = new GenericConversionService();
 		genericConversionService.addConverter(String.class, Long.class, new StringToLongConverter());
 		genericConversionService.addConverter(String.class, UUID.class, new StringToUUIDConverter());
 		this.conversionService = genericConversionService;
 	}
 
-	public AclClassIdUtils(ConversionService conversionService) {
+	AclClassIdUtils(ConversionService conversionService) {
 		Assert.notNull(conversionService, "conversionService must not be null");
 		this.conversionService = conversionService;
 	}

+ 2 - 2
acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java

@@ -559,7 +559,7 @@ public class BasicLookupStrategy implements LookupStrategy {
 		private final Map<Serializable, Acl> acls;
 		private final List<Sid> sids;
 
-		public ProcessResultSet(Map<Serializable, Acl> acls, List<Sid> sids) {
+		ProcessResultSet(Map<Serializable, Acl> acls, List<Sid> sids) {
 			Assert.notNull(acls, "ACLs cannot be null");
 			this.acls = acls;
 			this.sids = sids; // can be null
@@ -683,7 +683,7 @@ public class BasicLookupStrategy implements LookupStrategy {
 	private static class StubAclParent implements Acl {
 		private final Long id;
 
-		public StubAclParent(Long id) {
+		StubAclParent(Long id) {
 			this.id = id;
 		}
 

+ 2 - 2
cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java

@@ -55,8 +55,8 @@ class AssertionImplMixin {
 	 * @param attributes the key/value pairs for this attribute.
 	 */
 	@JsonCreator
-	public AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal,
+	AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal,
 								@JsonProperty("validFromDate") Date validFromDate, @JsonProperty("validUntilDate") Date validUntilDate,
 								@JsonProperty("authenticationDate") Date authenticationDate, @JsonProperty("attributes") Map<String, Object> attributes){
 	}
-}
+}

+ 2 - 2
cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java

@@ -51,8 +51,8 @@ class AttributePrincipalImplMixin {
 	 * @param proxyRetriever the ProxyRetriever implementation to call back to the CAS server.
 	 */
 	@JsonCreator
-	public AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map<String, Object> attributes,
+	AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map<String, Object> attributes,
 										@JsonProperty("proxyGrantingTicket") String proxyGrantingTicket,
 										@JsonProperty("proxyRetriever") ProxyRetriever proxyRetriever) {
 	}
-}
+}

+ 1 - 1
cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java

@@ -69,7 +69,7 @@ class CasAuthenticationTokenMixin {
 	 * principal and how to obtain a proxy ticket for the user.
 	 */
 	@JsonCreator
-	public CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
+	CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
 										@JsonProperty("credentials") Object credentials,
 										@JsonProperty("authorities") Collection<? extends GrantedAuthority> authorities,
 										@JsonProperty("userDetails") UserDetails userDetails, @JsonProperty("assertion") Assertion assertion) {

+ 2 - 2
cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java

@@ -415,7 +415,7 @@ public class CasAuthenticationFilter extends AbstractAuthenticationProcessingFil
 	private class CasAuthenticationFailureHandler implements AuthenticationFailureHandler {
 		private final AuthenticationFailureHandler serviceTicketFailureHandler;
 
-		public CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) {
+		CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) {
 			Assert.notNull(failureHandler, "failureHandler");
 			this.serviceTicketFailureHandler = failureHandler;
 		}
@@ -432,4 +432,4 @@ public class CasAuthenticationFilter extends AbstractAuthenticationProcessingFil
 			}
 		}
 	}
-}
+}

+ 1 - 1
cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java

@@ -414,7 +414,7 @@ public class CasAuthenticationProviderTests {
 	private class MockTicketValidator implements TicketValidator {
 		private boolean returnTicket;
 
-		public MockTicketValidator(boolean returnTicket) {
+		MockTicketValidator(boolean returnTicket) {
 			this.returnTicket = returnTicket;
 		}
 

+ 1 - 1
config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java

@@ -193,7 +193,7 @@ public class AuthenticationConfiguration {
 		private static final Log logger = LogFactory
 				.getLog(EnableGlobalAuthenticationAutowiredConfigurer.class);
 
-		public EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
+		EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) {
 			this.context = context;
 		}
 

+ 2 - 2
config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java

@@ -42,7 +42,7 @@ class InitializeAuthenticationProviderBeanManagerConfigurer
 	/**
 	 * @param context the ApplicationContext to look up beans.
 	 */
-	public InitializeAuthenticationProviderBeanManagerConfigurer(
+	InitializeAuthenticationProviderBeanManagerConfigurer(
 			ApplicationContext context) {
 		this.context = context;
 	}
@@ -83,4 +83,4 @@ class InitializeAuthenticationProviderBeanManagerConfigurer
 					.getBean(userDetailsBeanNames[0], type);
 		}
 	}
-}
+}

+ 1 - 1
config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java

@@ -43,7 +43,7 @@ class InitializeUserDetailsBeanManagerConfigurer
 	/**
 	 * @param context
 	 */
-	public InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
+	InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) {
 		this.context = context;
 	}
 

+ 1 - 1
config/src/main/java/org/springframework/security/config/annotation/configuration/AutowireBeanFactoryObjectPostProcessor.java

@@ -44,7 +44,7 @@ final class AutowireBeanFactoryObjectPostProcessor
 	private final List<DisposableBean> disposableBeans = new ArrayList<>();
 	private final List<SmartInitializingSingleton> smartSingletons = new ArrayList<>();
 
-	public AutowireBeanFactoryObjectPostProcessor(
+	AutowireBeanFactoryObjectPostProcessor(
 			AutowireCapableBeanFactory autowireBeanFactory) {
 		Assert.notNull(autowireBeanFactory, "autowireBeanFactory cannot be null");
 		this.autowireBeanFactory = autowireBeanFactory;

+ 1 - 1
config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecuritySelector.java

@@ -36,7 +36,7 @@ import org.springframework.util.ClassUtils;
  */
 final class GlobalMethodSecuritySelector implements ImportSelector {
 
-	public final String[] selectImports(AnnotationMetadata importingClassMetadata) {
+	public String[] selectImports(AnnotationMetadata importingClassMetadata) {
 		Class<EnableGlobalMethodSecurity> annoType = EnableGlobalMethodSecurity.class;
 		Map<String, Object> annotationAttributes = importingClassMetadata
 				.getAnnotationAttributes(annoType.getName(), false);

+ 1 - 1
config/src/main/java/org/springframework/security/config/annotation/web/configuration/AutowiredWebSecurityConfigurersIgnoreParents.java

@@ -40,7 +40,7 @@ final class AutowiredWebSecurityConfigurersIgnoreParents {
 
 	private final ConfigurableListableBeanFactory beanFactory;
 
-	public AutowiredWebSecurityConfigurersIgnoreParents(
+	AutowiredWebSecurityConfigurersIgnoreParents(
 			ConfigurableListableBeanFactory beanFactory) {
 		Assert.notNull(beanFactory, "beanFactory cannot be null");
 		this.beanFactory = beanFactory;

+ 2 - 2
config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java

@@ -183,7 +183,7 @@ public final class ExpressionUrlAuthorizationConfigurer<H extends HttpSecurityBu
 
 	@Override
 	@SuppressWarnings("rawtypes")
-	final List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
+	List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
 		List<AccessDecisionVoter<?>> decisionVoters = new ArrayList<>();
 		WebExpressionVoter expressionVoter = new WebExpressionVoter();
 		expressionVoter.setExpressionHandler(getExpressionHandler(http));
@@ -192,7 +192,7 @@ public final class ExpressionUrlAuthorizationConfigurer<H extends HttpSecurityBu
 	}
 
 	@Override
-	final ExpressionBasedFilterInvocationSecurityMetadataSource createMetadataSource(
+	ExpressionBasedFilterInvocationSecurityMetadataSource createMetadataSource(
 			H http) {
 		LinkedHashMap<RequestMatcher, Collection<ConfigAttribute>> requestMap = REGISTRY
 				.createRequestMap();

+ 1 - 1
config/src/main/java/org/springframework/security/config/annotation/web/configurers/UrlAuthorizationConfigurer.java

@@ -172,7 +172,7 @@ public final class UrlAuthorizationConfigurer<H extends HttpSecurityBuilder<H>>
 	 */
 	@Override
 	@SuppressWarnings("rawtypes")
-	final List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
+	List<AccessDecisionVoter<?>> getDecisionVoters(H http) {
 		List<AccessDecisionVoter<?>> decisionVoters = new ArrayList<>();
 		decisionVoters.add(new RoleVoter());
 		decisionVoters.add(new AuthenticatedVoter());

+ 1 - 1
config/src/main/java/org/springframework/security/config/crypto/RsaKeyConversionServicePostProcessor.java

@@ -133,7 +133,7 @@ public class RsaKeyConversionServicePostProcessor implements BeanFactoryPostProc
 	private static class ConverterPropertyEditorAdapter<T> extends PropertyEditorSupport {
 		private final Converter<String, T> converter;
 
-		public ConverterPropertyEditorAdapter(Converter<String, T> converter) {
+		ConverterPropertyEditorAdapter(Converter<String, T> converter) {
 			this.converter = converter;
 		}
 

+ 1 - 1
config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java

@@ -138,7 +138,7 @@ final class AuthenticationConfigBuilder {
 
 	private String openIDLoginPage;
 
-	public AuthenticationConfigBuilder(Element element, boolean forceAutoConfig,
+	AuthenticationConfigBuilder(Element element, boolean forceAutoConfig,
 			ParserContext pc, SessionCreationPolicy sessionPolicy,
 			BeanReference requestCache, BeanReference authenticationManager,
 			BeanReference sessionStrategy, BeanReference portMapper,

+ 1 - 1
config/src/main/java/org/springframework/security/config/http/HttpConfigurationBuilder.java

@@ -152,7 +152,7 @@ class HttpConfigurationBuilder {
 	private BeanDefinition invalidSession;
 	private boolean addAllAuth;
 
-	public HttpConfigurationBuilder(Element element, boolean addAllAuth,
+	HttpConfigurationBuilder(Element element, boolean addAllAuth,
 			ParserContext pc, BeanReference portMapper, BeanReference portResolver,
 			BeanReference authenticationManager) {
 		this.httpElt = element;

+ 2 - 2
config/src/main/java/org/springframework/security/config/http/HttpSecurityBeanDefinitionParser.java

@@ -415,12 +415,12 @@ class OrderDecorator implements Ordered {
 	final BeanMetadataElement bean;
 	final int order;
 
-	public OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) {
+	OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) {
 		this.bean = bean;
 		this.order = filterOrder.getOrder();
 	}
 
-	public OrderDecorator(BeanMetadataElement bean, int order) {
+	OrderDecorator(BeanMetadataElement bean, int order) {
 		this.bean = bean;
 		this.order = order;
 	}

+ 1 - 1
config/src/main/java/org/springframework/security/config/http/LogoutBeanDefinitionParser.java

@@ -48,7 +48,7 @@ class LogoutBeanDefinitionParser implements BeanDefinitionParser {
 	private ManagedList<BeanMetadataElement> logoutHandlers = new ManagedList<>();
 	private boolean csrfEnabled;
 
-	public LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices,
+	LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices,
 			BeanMetadataElement csrfLogoutHandler) {
 		this.defaultLogoutUrl = loginPageUrl + "?logout";
 		this.rememberMeServices = rememberMeServices;

+ 1 - 1
config/src/main/java/org/springframework/security/config/method/ProtectPointcutPostProcessor.java

@@ -68,7 +68,7 @@ final class ProtectPointcutPostProcessor implements BeanPostProcessor {
 	private final PointcutParser parser;
 	private final Set<String> processedBeans = new HashSet<>();
 
-	public ProtectPointcutPostProcessor(
+	ProtectPointcutPostProcessor(
 			MapBasedMethodSecurityMetadataSource mapBasedMethodSecurityMetadataSource) {
 		Assert.notNull(mapBasedMethodSecurityMetadataSource,
 				"MapBasedMethodSecurityMetadataSource to populate is required");

+ 1 - 1
config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java

@@ -3645,7 +3645,7 @@ public class ServerHttpSecurity {
 		private final WebFilter webFilter;
 		private final int order;
 
-		public OrderedWebFilter(WebFilter webFilter, int order) {
+		OrderedWebFilter(WebFilter webFilter, int order) {
 			this.webFilter = webFilter;
 			this.order = order;
 		}

+ 1 - 2
config/src/main/java/org/springframework/security/config/websocket/WebSocketMessageBrokerSecurityBeanDefinitionParser.java

@@ -243,8 +243,7 @@ public final class WebSocketMessageBrokerSecurityBeanDefinitionParser implements
 
 		private final boolean sameOriginDisabled;
 
-		public MessageSecurityPostProcessor(String inboundSecurityInterceptorId,
-				boolean sameOriginDisabled) {
+		MessageSecurityPostProcessor(String inboundSecurityInterceptorId, boolean sameOriginDisabled) {
 			this.inboundSecurityInterceptorId = inboundSecurityInterceptorId;
 			this.sameOriginDisabled = sameOriginDisabled;
 		}

+ 1 - 1
config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java

@@ -41,7 +41,7 @@ public class SecurityConfigurerAdapterTests {
 	static class OrderedObjectPostProcessor implements ObjectPostProcessor<String>, Ordered {
 		private final int order;
 
-		public OrderedObjectPostProcessor(int order) {
+		OrderedObjectPostProcessor(int order) {
 			this.order = order;
 		}
 

+ 1 - 1
config/src/test/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurerTests.java

@@ -847,7 +847,7 @@ public class ExpressionUrlAuthorizationConfigurerTests {
 
 		static class CustomExpressionRoot extends WebSecurityExpressionRoot {
 
-			public CustomExpressionRoot(Authentication a, FilterInvocation fi) {
+			CustomExpressionRoot(Authentication a, FilterInvocation fi) {
 				super(a, fi);
 			}
 

+ 1 - 1
config/src/test/java/org/springframework/security/config/annotation/web/configurers/NamespaceHttpExpressionHandlerTests.java

@@ -73,7 +73,7 @@ public class NamespaceHttpExpressionHandlerTests {
 	@EnableWebMvc
 	@EnableWebSecurity
 	private static class ExpressionHandlerConfig extends WebSecurityConfigurerAdapter {
-		public ExpressionHandlerConfig() {}
+		ExpressionHandlerConfig() {}
 
 		@Override
 		protected void configure(AuthenticationManagerBuilder auth) throws Exception {

+ 1 - 1
config/src/test/java/org/springframework/security/config/annotation/web/configurers/SecurityContextConfigurerTests.java

@@ -129,7 +129,7 @@ public class SecurityContextConfigurerTests {
 	@Configuration
 	@EnableWebSecurity
 	static class SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig extends WebSecurityConfigurerAdapter {
-		public SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() {
+		SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() {
 			super(true);
 		}
 

+ 2 - 2
config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java

@@ -2133,7 +2133,7 @@ public class OAuth2ResourceServerConfigurerTests {
 
 		private class MockWebServerPropertySource extends PropertySource {
 
-			public MockWebServerPropertySource() {
+			MockWebServerPropertySource() {
 				super("mockwebserver");
 			}
 
@@ -2178,7 +2178,7 @@ public class OAuth2ResourceServerConfigurerTests {
 
 		private String token;
 
-		public BearerTokenRequestPostProcessor(String token) {
+		BearerTokenRequestPostProcessor(String token) {
 			this.token = token;
 		}
 

+ 1 - 1
config/src/test/java/org/springframework/security/config/http/CsrfConfigTests.java

@@ -631,7 +631,7 @@ public class CsrfConfigTests {
 	static class CsrfReturnedResultMatcher implements ResultMatcher {
 		ExceptionalFunction<MvcResult, String> token;
 
-		public CsrfReturnedResultMatcher(ExceptionalFunction<MvcResult, String> token) {
+		CsrfReturnedResultMatcher(ExceptionalFunction<MvcResult, String> token) {
 			this.token = token;
 		}
 

+ 1 - 1
config/src/test/java/org/springframework/security/config/http/HttpConfigTests.java

@@ -83,7 +83,7 @@ public class HttpConfigTests {
 	private static class EncodeUrlDenyingHttpServletResponseWrapper
 			extends HttpServletResponseWrapper {
 
-		public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
+		EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
 			super(response);
 		}
 

+ 1 - 1
config/src/test/java/org/springframework/security/config/http/MiscHttpConfigTests.java

@@ -907,7 +907,7 @@ public class MiscHttpConfigTests {
 	static class EncodeUrlDenyingHttpServletResponseWrapper
 			extends HttpServletResponseWrapper {
 
-		public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
+		EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
 			super(response);
 		}
 

+ 1 - 1
config/src/test/java/org/springframework/security/config/http/SessionManagementConfigTests.java

@@ -610,7 +610,7 @@ public class SessionManagementConfigTests {
 	private static class EncodeUrlDenyingHttpServletResponseWrapper
 			extends HttpServletResponseWrapper {
 
-		public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
+		EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) {
 			super(response);
 		}
 

+ 1 - 1
config/src/test/java/org/springframework/security/htmlunit/server/HtmlUnitWebTestClient.java

@@ -51,7 +51,7 @@ final class HtmlUnitWebTestClient {
 
 	private final WebTestClient webTestClient;
 
-	public HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) {
+	HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) {
 		Assert.notNull(webClient, "WebClient must not be null");
 		Assert.notNull(webTestClient, "WebTestClient must not be null");
 		this.webClient = webClient;

+ 1 - 1
config/src/test/java/org/springframework/security/htmlunit/server/MockWebResponseBuilder.java

@@ -42,7 +42,7 @@ final class MockWebResponseBuilder {
 	private final FluxExchangeResult<String> exchangeResult;
 
 
-	public MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult<String> exchangeResult) {
+	MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult<String> exchangeResult) {
 		Assert.notNull(webRequest, "WebRequest must not be null");
 		Assert.notNull(exchangeResult, "FluxExchangeResult must not be null");
 		this.startTime = startTime;

+ 2 - 2
core/src/main/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContext.java

@@ -48,11 +48,11 @@ class MethodSecurityEvaluationContext extends StandardEvaluationContext {
 	 * for each instance. Use the constructor which takes the resolver, as an argument
 	 * thus allowing for caching.
 	 */
-	public MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi) {
+	MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi) {
 		this(user, mi, new DefaultSecurityParameterNameDiscoverer());
 	}
 
-	public MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi,
+	MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi,
 			ParameterNameDiscoverer parameterNameDiscoverer) {
 		this.mi = mi;
 		this.parameterNameDiscoverer = parameterNameDiscoverer;

+ 1 - 1
core/src/main/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java

@@ -116,7 +116,7 @@ public final class DelegatingMethodSecurityMetadataSource extends
 		private final Method method;
 		private final Class<?> targetClass;
 
-		public DefaultCacheKey(Method method, Class<?> targetClass) {
+		DefaultCacheKey(Method method, Class<?> targetClass) {
 			this.method = method;
 			this.targetClass = targetClass;
 		}

+ 1 - 1
core/src/main/java/org/springframework/security/access/method/MapBasedMethodSecurityMetadataSource.java

@@ -287,7 +287,7 @@ public class MapBasedMethodSecurityMetadataSource extends
 		private final Method method;
 		private final Class<?> registeredJavaType;
 
-		public RegisteredMethod(Method method, Class<?> registeredJavaType) {
+		RegisteredMethod(Method method, Class<?> registeredJavaType) {
 			Assert.notNull(method, "Method required");
 			Assert.notNull(registeredJavaType, "Registered Java Type required");
 			this.method = method;

+ 1 - 1
core/src/main/java/org/springframework/security/authentication/jaas/AbstractJaasAuthenticationProvider.java

@@ -402,7 +402,7 @@ public abstract class AbstractJaasAuthenticationProvider
 	private class InternalCallbackHandler implements CallbackHandler {
 		private final Authentication authentication;
 
-		public InternalCallbackHandler(Authentication authentication) {
+		InternalCallbackHandler(Authentication authentication) {
 			this.authentication = authentication;
 		}
 

+ 5 - 5
core/src/main/java/org/springframework/security/concurrent/DelegatingSecurityContextScheduledExecutorService.java

@@ -61,24 +61,24 @@ public final class DelegatingSecurityContextScheduledExecutorService extends
 		this(delegate, null);
 	}
 
-	public final ScheduledFuture<?> schedule(Runnable command, long delay, TimeUnit unit) {
+	public ScheduledFuture<?> schedule(Runnable command, long delay, TimeUnit unit) {
 		command = wrap(command);
 		return getDelegate().schedule(command, delay, unit);
 	}
 
-	public final <V> ScheduledFuture<V> schedule(Callable<V> callable, long delay,
+	public <V> ScheduledFuture<V> schedule(Callable<V> callable, long delay,
 			TimeUnit unit) {
 		callable = wrap(callable);
 		return getDelegate().schedule(callable, delay, unit);
 	}
 
-	public final ScheduledFuture<?> scheduleAtFixedRate(Runnable command,
+	public ScheduledFuture<?> scheduleAtFixedRate(Runnable command,
 			long initialDelay, long period, TimeUnit unit) {
 		command = wrap(command);
 		return getDelegate().scheduleAtFixedRate(command, initialDelay, period, unit);
 	}
 
-	public final ScheduledFuture<?> scheduleWithFixedDelay(Runnable command,
+	public ScheduledFuture<?> scheduleWithFixedDelay(Runnable command,
 			long initialDelay, long delay, TimeUnit unit) {
 		command = wrap(command);
 		return getDelegate().scheduleWithFixedDelay(command, initialDelay, delay, unit);
@@ -87,4 +87,4 @@ public final class DelegatingSecurityContextScheduledExecutorService extends
 	private ScheduledExecutorService getDelegate() {
 		return (ScheduledExecutorService) getDelegateExecutor();
 	}
-}
+}

+ 3 - 3
core/src/main/java/org/springframework/security/core/ComparableVersion.java

@@ -117,7 +117,7 @@ class ComparableVersion implements Comparable<ComparableVersion> {
 			this.value = BigInteger_ZERO;
 		}
 
-		public IntegerItem(String str) {
+		IntegerItem(String str) {
 			this.value = new BigInteger(str);
 		}
 
@@ -184,7 +184,7 @@ class ComparableVersion implements Comparable<ComparableVersion> {
 
 		private String value;
 
-		public StringItem(String value, boolean followedByDigit) {
+		StringItem(String value, boolean followedByDigit) {
 			if (followedByDigit && value.length() == 1) {
 				// a1 = alpha-1, b1 = beta-1, m1 = milestone-1
 				switch (value.charAt(0)) {
@@ -341,7 +341,7 @@ class ComparableVersion implements Comparable<ComparableVersion> {
 		}
 	}
 
-	public ComparableVersion(String version) {
+	ComparableVersion(String version) {
 		parseVersion(version);
 	}
 

+ 1 - 1
core/src/main/java/org/springframework/security/jackson2/AnonymousAuthenticationTokenMixin.java

@@ -53,7 +53,7 @@ class AnonymousAuthenticationTokenMixin {
 	 * @param authorities the authorities granted to the principal
 	 */
 	@JsonCreator
-	public AnonymousAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
+	AnonymousAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal,
 												@JsonProperty("authorities") Collection<? extends GrantedAuthority> authorities) {
 	}
 }

+ 1 - 1
core/src/main/java/org/springframework/security/jackson2/RememberMeAuthenticationTokenMixin.java

@@ -59,7 +59,7 @@ class RememberMeAuthenticationTokenMixin {
 	 * @param authorities the authorities granted to the principal
 	 */
 	@JsonCreator
-	public RememberMeAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash,
+	RememberMeAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash,
 												@JsonProperty("principal") Object principal,
 												@JsonProperty("authorities") Collection<? extends GrantedAuthority> authorities) {
 	}

+ 1 - 1
core/src/main/java/org/springframework/security/jackson2/SecurityJackson2Modules.java

@@ -152,7 +152,7 @@ public final class SecurityJackson2Modules {
 	 */
 	static class WhitelistTypeResolverBuilder extends ObjectMapper.DefaultTypeResolverBuilder {
 
-		public WhitelistTypeResolverBuilder(ObjectMapper.DefaultTyping defaultTyping) {
+		WhitelistTypeResolverBuilder(ObjectMapper.DefaultTyping defaultTyping) {
 			super(defaultTyping);
 		}
 

+ 1 - 1
core/src/main/java/org/springframework/security/provisioning/MutableUser.java

@@ -33,7 +33,7 @@ class MutableUser implements MutableUserDetails {
 	private String password;
 	private final UserDetails delegate;
 
-	public MutableUser(UserDetails user) {
+	MutableUser(UserDetails user) {
 		this.delegate = user;
 		this.password = user.getPassword();
 	}

+ 1 - 1
core/src/test/java/org/springframework/security/access/SecurityConfigTests.java

@@ -92,7 +92,7 @@ public class SecurityConfigTests {
 	private class MockConfigAttribute implements ConfigAttribute {
 		private String attribute;
 
-		public MockConfigAttribute(String configuration) {
+		MockConfigAttribute(String configuration) {
 			this.attribute = configuration;
 		}
 

+ 10 - 10
core/src/test/java/org/springframework/security/access/annotation/BusinessService.java

@@ -35,31 +35,31 @@ public interface BusinessService extends Serializable {
 	@Secured({ "ROLE_ADMIN" })
 	@RolesAllowed({ "ROLE_ADMIN" })
 	@PreAuthorize("hasRole('ROLE_ADMIN')")
-	public void someAdminMethod();
+	void someAdminMethod();
 
 	@Secured({ "ROLE_USER", "ROLE_ADMIN" })
 	@RolesAllowed({ "ROLE_USER", "ROLE_ADMIN" })
-	public void someUserAndAdminMethod();
+	void someUserAndAdminMethod();
 
 	@Secured({ "ROLE_USER" })
 	@RolesAllowed({ "ROLE_USER" })
-	public void someUserMethod1();
+	void someUserMethod1();
 
 	@Secured({ "ROLE_USER" })
 	@RolesAllowed({ "ROLE_USER" })
-	public void someUserMethod2();
+	void someUserMethod2();
 
 	@RolesAllowed({ "USER" })
-	public void rolesAllowedUser();
+	void rolesAllowedUser();
 
-	public int someOther(String s);
+	int someOther(String s);
 
-	public int someOther(int input);
+	int someOther(int input);
 
-	public List<?> methodReturningAList(List<?> someList);
+	List<?> methodReturningAList(List<?> someList);
 
-	public Object[] methodReturningAnArray(Object[] someArray);
+	Object[] methodReturningAnArray(Object[] someArray);
 
-	public List<?> methodReturningAList(String userName, String extraParam);
+	List<?> methodReturningAList(String userName, String extraParam);
 
 }

+ 5 - 5
core/src/test/java/org/springframework/security/access/annotation/SecuredAnnotationSecurityMetadataSourceTests.java

@@ -218,7 +218,7 @@ public class SecuredAnnotationSecurityMetadataSourceTests {
 	// Inner classes
 	class Department extends Entity {
 
-		public Department(String name) {
+		Department(String name) {
 			super(name);
 		}
 	}
@@ -285,15 +285,15 @@ public class SecuredAnnotationSecurityMetadataSourceTests {
 	public @interface AnnotatedAnnotation {
 	}
 
-	public static interface ReturnVoid {
+	public interface ReturnVoid {
 
-		public void doSomething(List<?> param);
+		void doSomething(List<?> param);
 	}
 
 	@AnnotatedAnnotation
-	public static interface ReturnVoid2 {
+	public interface ReturnVoid2 {
 
-		public void doSomething(List<?> param);
+		void doSomething(List<?> param);
 	}
 
 	@AnnotatedAnnotation

+ 1 - 1
core/src/test/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContextTests.java

@@ -58,7 +58,7 @@ public class MethodSecurityEvaluationContextTests {
 	private static class  NotNullVariableMethodSecurityEvaluationContext
 			extends MethodSecurityEvaluationContext {
 
-		public NotNullVariableMethodSecurityEvaluationContext(Authentication auth, MethodInvocation mi,
+		NotNullVariableMethodSecurityEvaluationContext(Authentication auth, MethodInvocation mi,
 				ParameterNameDiscoverer parameterNameDiscoverer) {
 			super(auth, mi, parameterNameDiscoverer);
 		}

+ 8 - 8
core/src/test/java/org/springframework/security/access/expression/method/PrePostAnnotationSecurityMetadataSourceTests.java

@@ -203,19 +203,19 @@ public class PrePostAnnotationSecurityMetadataSourceTests {
 	// ~ Inner Classes
 	// ==================================================================================================
 
-	public static interface ReturnVoid {
-		public void doSomething(List<?> param);
+	public interface ReturnVoid {
+		void doSomething(List<?> param);
 	}
 
-	public static interface ReturnAList {
-		public List<?> doSomething(List<?> param);
+	public interface ReturnAList {
+		List<?> doSomething(List<?> param);
 	}
 
 	@PreAuthorize("interfaceAuthzExpression")
-	public static interface ReturnAnotherList {
+	public interface ReturnAnotherList {
 		@PreAuthorize("interfaceMethodAuthzExpression")
 		@PreFilter(filterTarget = "param", value = "interfacePreFilterExpression")
-		public List<?> doSomething(List<?> param);
+		List<?> doSomething(List<?> param);
 	}
 
 	@PreAuthorize("someExpression")
@@ -275,8 +275,8 @@ public class PrePostAnnotationSecurityMetadataSourceTests {
 	}
 
 	@CustomAnnotation
-	public static interface ReturnVoid2 {
-		public void doSomething(List<?> param);
+	public interface ReturnVoid2 {
+		void doSomething(List<?> param);
 	}
 
 	@CustomAnnotation

+ 1 - 2
core/src/test/java/org/springframework/security/access/intercept/AfterInvocationProviderManagerTests.java

@@ -179,8 +179,7 @@ public class AfterInvocationProviderManagerTests {
 
 		private Object forceReturnObject;
 
-		public MockAfterInvocationProvider(Object forceReturnObject, Class secureObject,
-				ConfigAttribute configAttribute) {
+		MockAfterInvocationProvider(Object forceReturnObject, Class secureObject, ConfigAttribute configAttribute) {
 			this.forceReturnObject = forceReturnObject;
 			this.secureObject = secureObject;
 			this.configAttribute = configAttribute;

+ 1 - 2
core/src/test/java/org/springframework/security/authentication/AbstractAuthenticationTokenTests.java

@@ -156,8 +156,7 @@ public class AbstractAuthenticationTokenTests {
 		private Object credentials;
 		private Object principal;
 
-		public MockAuthenticationImpl(Object principal, Object credentials,
-				List<GrantedAuthority> authorities) {
+		MockAuthenticationImpl(Object principal, Object credentials, List<GrantedAuthority> authorities) {
 			super(authorities);
 			this.principal = principal;
 			this.credentials = credentials;

+ 1 - 1
core/src/test/java/org/springframework/security/authentication/DefaultAuthenticationEventPublisherTests.java

@@ -139,7 +139,7 @@ public class DefaultAuthenticationEventPublisherTests {
 
 	private static final class MockAuthenticationException extends
 			AuthenticationException {
-		public MockAuthenticationException(String msg) {
+		MockAuthenticationException(String msg) {
 			super(msg);
 		}
 	}

+ 1 - 1
core/src/test/java/org/springframework/security/authentication/jaas/JaasAuthenticationProviderTests.java

@@ -290,7 +290,7 @@ public class JaasAuthenticationProviderTests {
 	private static class MockLoginContext extends LoginContext {
 		boolean loggedOut = false;
 
-		public MockLoginContext(String loginModule) throws LoginException {
+		MockLoginContext(String loginModule) throws LoginException {
 			super(loginModule);
 		}
 

+ 1 - 1
core/src/test/java/org/springframework/security/authentication/rcp/RemoteAuthenticationProviderTests.java

@@ -119,7 +119,7 @@ public class RemoteAuthenticationProviderTests {
 	private class MockRemoteAuthenticationManager implements RemoteAuthenticationManager {
 		private boolean grantAccess;
 
-		public MockRemoteAuthenticationManager(boolean grantAccess) {
+		MockRemoteAuthenticationManager(boolean grantAccess) {
 			this.grantAccess = grantAccess;
 		}
 

+ 2 - 2
core/src/test/java/org/springframework/security/concurrent/DelegatingSecurityContextSupportTests.java

@@ -62,8 +62,8 @@ public class DelegatingSecurityContextSupportTests extends
 
 	private static class ConcreteDelegatingSecurityContextSupport extends
 			AbstractDelegatingSecurityContextSupport {
-		public ConcreteDelegatingSecurityContextSupport(SecurityContext securityContext) {
+		ConcreteDelegatingSecurityContextSupport(SecurityContext securityContext) {
 			super(securityContext);
 		}
 	}
-}
+}

+ 2 - 2
core/src/test/java/org/springframework/security/core/parameters/AnnotationParameterNameDiscovererTests.java

@@ -148,10 +148,10 @@ public class AnnotationParameterNameDiscovererTests {
 	}
 
 	static class Impl {
-		public Impl(Long dataSourceId) {
+		Impl(Long dataSourceId) {
 		}
 
-		public Impl(@P("id") String dataSourceId) {
+		Impl(@P("id") String dataSourceId) {
 		}
 
 		String findMessageByTo(@P("to") String to) {

+ 1 - 1
crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java

@@ -485,7 +485,7 @@ public class BCrypt {
 	 * @param lr	an array containing the two 32-bit half blocks
 	 * @param off	the position in the array of the blocks
 	 */
-	private final void encipher(int lr[], int off) {
+	private void encipher(int lr[], int off) {
 		int i, n, l = lr[off], r = lr[off + 1];
 
 		l ^= P[0];

+ 1 - 1
crypto/src/main/java/org/springframework/security/crypto/encrypt/HexEncodingTextEncryptor.java

@@ -28,7 +28,7 @@ final class HexEncodingTextEncryptor implements TextEncryptor {
 
 	private final BytesEncryptor encryptor;
 
-	public HexEncodingTextEncryptor(BytesEncryptor encryptor) {
+	HexEncodingTextEncryptor(BytesEncryptor encryptor) {
 		this.encryptor = encryptor;
 	}
 

+ 1 - 1
crypto/src/main/java/org/springframework/security/crypto/keygen/HexEncodingStringKeyGenerator.java

@@ -26,7 +26,7 @@ final class HexEncodingStringKeyGenerator implements StringKeyGenerator {
 
 	private final BytesKeyGenerator keyGenerator;
 
-	public HexEncodingStringKeyGenerator(BytesKeyGenerator keyGenerator) {
+	HexEncodingStringKeyGenerator(BytesKeyGenerator keyGenerator) {
 		this.keyGenerator = keyGenerator;
 	}
 

+ 2 - 2
crypto/src/main/java/org/springframework/security/crypto/keygen/SecureRandomBytesKeyGenerator.java

@@ -34,14 +34,14 @@ final class SecureRandomBytesKeyGenerator implements BytesKeyGenerator {
 	/**
 	 * Creates a secure random key generator using the defaults.
 	 */
-	public SecureRandomBytesKeyGenerator() {
+	SecureRandomBytesKeyGenerator() {
 		this(DEFAULT_KEY_LENGTH);
 	}
 
 	/**
 	 * Creates a secure random key generator with a custom key length.
 	 */
-	public SecureRandomBytesKeyGenerator(int keyLength) {
+	SecureRandomBytesKeyGenerator(int keyLength) {
 		this.random = new SecureRandom();
 		this.keyLength = keyLength;
 	}

+ 2 - 2
crypto/src/main/java/org/springframework/security/crypto/keygen/SharedKeyGenerator.java

@@ -26,7 +26,7 @@ final class SharedKeyGenerator implements BytesKeyGenerator {
 
 	private byte[] sharedKey;
 
-	public SharedKeyGenerator(byte[] sharedKey) {
+	SharedKeyGenerator(byte[] sharedKey) {
 		this.sharedKey = sharedKey;
 	}
 
@@ -38,4 +38,4 @@ final class SharedKeyGenerator implements BytesKeyGenerator {
 		return sharedKey;
 	}
 
-}
+}

+ 2 - 2
crypto/src/main/java/org/springframework/security/crypto/password/Digester.java

@@ -38,7 +38,7 @@ final class Digester {
 	 * @param algorithm the digest algorithm; for example, "SHA-1" or "SHA-256".
 	 * @param iterations the number of times to apply the digest algorithm to the input
 	 */
-	public Digester(String algorithm, int iterations) {
+	Digester(String algorithm, int iterations) {
 		// eagerly validate the algorithm
 		createDigest(algorithm);
 		this.algorithm = algorithm;
@@ -53,7 +53,7 @@ final class Digester {
 		return value;
 	}
 
-	final void setIterations(int iterations) {
+	void setIterations(int iterations) {
 		if (iterations <= 0) {
 			throw new IllegalArgumentException("Iterations value must be greater than zero");
 		}

+ 1 - 1
crypto/src/test/java/org/springframework/security/crypto/encrypt/BouncyCastleAesBytesEncryptorEquivalencyTest.java

@@ -126,7 +126,7 @@ public class BouncyCastleAesBytesEncryptorEquivalencyTest {
 
 		private final int keyLength;
 
-		public PredictableRandomBytesKeyGenerator(int keyLength) {
+		PredictableRandomBytesKeyGenerator(int keyLength) {
 			this.random = new Random(1);
 			this.keyLength = keyLength;
 		}

+ 1 - 1
ldap/src/integration-test/java/org/springframework/security/ldap/DefaultSpringSecurityContextSourceTests.java

@@ -151,7 +151,7 @@ public class DefaultSpringSecurityContextSourceTests extends AbstractLdapIntegra
 
 	static class EnvExposingDefaultSpringSecurityContextSource extends
 			DefaultSpringSecurityContextSource {
-		public EnvExposingDefaultSpringSecurityContextSource(String providerUrl) {
+		EnvExposingDefaultSpringSecurityContextSource(String providerUrl) {
 			super(providerUrl);
 		}
 

+ 1 - 1
ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java

@@ -493,7 +493,7 @@ public class LdapUserDetailsManager implements UserDetailsManager {
 
 		private final ByteArrayOutputStream value = new ByteArrayOutputStream();
 
-		public PasswordModifyRequest(String userIdentity, String oldPassword, String newPassword) {
+		PasswordModifyRequest(String userIdentity, String oldPassword, String newPassword) {
 			ByteArrayOutputStream elements = new ByteArrayOutputStream();
 
 			if (userIdentity != null) {

+ 1 - 1
ldap/src/test/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java

@@ -468,7 +468,7 @@ public class ActiveDirectoryLdapAuthenticationProviderTests {
 	static class MockNamingEnumeration implements NamingEnumeration<SearchResult> {
 		private SearchResult sr;
 
-		public MockNamingEnumeration(SearchResult sr) {
+		MockNamingEnumeration(SearchResult sr) {
 			this.sr = sr;
 		}
 

+ 1 - 1
messaging/src/main/java/org/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java

@@ -44,7 +44,7 @@ class MessageExpressionConfigAttribute implements ConfigAttribute, EvaluationCon
 	 * @param authorizeExpression the {@link Expression} to use. Cannot be null
 	 * @param matcher the {@link MessageMatcher} used to match the messages.
 	 */
-	public MessageExpressionConfigAttribute(Expression authorizeExpression, MessageMatcher<?> matcher) {
+	MessageExpressionConfigAttribute(Expression authorizeExpression, MessageMatcher<?> matcher) {
 		Assert.notNull(authorizeExpression, "authorizeExpression cannot be null");
 		Assert.notNull(matcher, "matcher cannot be null");
 		this.authorizeExpression = authorizeExpression;

+ 2 - 2
messaging/src/main/java/org/springframework/security/messaging/util/matcher/AbstractMessageMatcherComposite.java

@@ -38,7 +38,7 @@ abstract class AbstractMessageMatcherComposite<T> implements MessageMatcher<T> {
 	 *
 	 * @param messageMatchers the {@link MessageMatcher} instances to try
 	 */
-	public AbstractMessageMatcherComposite(List<MessageMatcher<T>> messageMatchers) {
+	AbstractMessageMatcherComposite(List<MessageMatcher<T>> messageMatchers) {
 		notEmpty(messageMatchers, "messageMatchers must contain a value");
 		if (messageMatchers.contains(null)) {
 			throw new IllegalArgumentException(
@@ -54,7 +54,7 @@ abstract class AbstractMessageMatcherComposite<T> implements MessageMatcher<T> {
 	 * @param messageMatchers the {@link MessageMatcher} instances to try
 	 */
 	@SafeVarargs
-	public AbstractMessageMatcherComposite(MessageMatcher<T>... messageMatchers) {
+	AbstractMessageMatcherComposite(MessageMatcher<T>... messageMatchers) {
 		this(asList(messageMatchers));
 	}
 

+ 1 - 1
messaging/src/test/java/org/springframework/security/messaging/context/AuthenticationPrincipalArgumentResolverTests.java

@@ -265,7 +265,7 @@ public class AuthenticationPrincipalArgumentResolverTests {
 			this.property = property;
 		}
 
-		public CopyUserPrincipal(CopyUserPrincipal toCopy) {
+		CopyUserPrincipal(CopyUserPrincipal toCopy) {
 			this.property = toCopy.property;
 		}
 

+ 3 - 3
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenDecoderFactory.java

@@ -194,7 +194,7 @@ public final class OidcIdTokenDecoderFactory implements JwtDecoderFactory<Client
 	 *
 	 * @param jwtValidatorFactory the factory that provides an {@link OAuth2TokenValidator}
 	 */
-	public final void setJwtValidatorFactory(Function<ClientRegistration, OAuth2TokenValidator<Jwt>> jwtValidatorFactory) {
+	public void setJwtValidatorFactory(Function<ClientRegistration, OAuth2TokenValidator<Jwt>> jwtValidatorFactory) {
 		Assert.notNull(jwtValidatorFactory, "jwtValidatorFactory cannot be null");
 		this.jwtValidatorFactory = jwtValidatorFactory;
 	}
@@ -207,7 +207,7 @@ public final class OidcIdTokenDecoderFactory implements JwtDecoderFactory<Client
 	 * @param jwsAlgorithmResolver the resolver that provides the expected {@link JwsAlgorithm JWS algorithm}
 	 *                             for a specific {@link ClientRegistration client}
 	 */
-	public final void setJwsAlgorithmResolver(Function<ClientRegistration, JwsAlgorithm> jwsAlgorithmResolver) {
+	public void setJwsAlgorithmResolver(Function<ClientRegistration, JwsAlgorithm> jwsAlgorithmResolver) {
 		Assert.notNull(jwsAlgorithmResolver, "jwsAlgorithmResolver cannot be null");
 		this.jwsAlgorithmResolver = jwsAlgorithmResolver;
 	}
@@ -219,7 +219,7 @@ public final class OidcIdTokenDecoderFactory implements JwtDecoderFactory<Client
 	 * @param claimTypeConverterFactory the factory that provides a {@link Converter} used for type conversion
 	 *                                  of claim values for a specific {@link ClientRegistration client}
 	 */
-	public final void setClaimTypeConverterFactory(Function<ClientRegistration, Converter<Map<String, Object>, Map<String, Object>>> claimTypeConverterFactory) {
+	public void setClaimTypeConverterFactory(Function<ClientRegistration, Converter<Map<String, Object>, Map<String, Object>>> claimTypeConverterFactory) {
 		Assert.notNull(claimTypeConverterFactory, "claimTypeConverterFactory cannot be null");
 		this.claimTypeConverterFactory = claimTypeConverterFactory;
 	}

+ 1 - 1
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenValidator.java

@@ -130,7 +130,7 @@ public final class OidcIdTokenValidator implements OAuth2TokenValidator<Jwt> {
 	 * @since 5.2
 	 * @param clockSkew the maximum acceptable clock skew
 	 */
-	public final void setClockSkew(Duration clockSkew) {
+	public void setClockSkew(Duration clockSkew) {
 		Assert.notNull(clockSkew, "clockSkew cannot be null");
 		Assert.isTrue(clockSkew.getSeconds() >= 0, "clockSkew must be >= 0");
 		this.clockSkew = clockSkew;

+ 3 - 3
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java

@@ -194,7 +194,7 @@ public final class ReactiveOidcIdTokenDecoderFactory implements ReactiveJwtDecod
 	 *
 	 * @param jwtValidatorFactory the factory that provides an {@link OAuth2TokenValidator}
 	 */
-	public final void setJwtValidatorFactory(Function<ClientRegistration, OAuth2TokenValidator<Jwt>> jwtValidatorFactory) {
+	public void setJwtValidatorFactory(Function<ClientRegistration, OAuth2TokenValidator<Jwt>> jwtValidatorFactory) {
 		Assert.notNull(jwtValidatorFactory, "jwtValidatorFactory cannot be null");
 		this.jwtValidatorFactory = jwtValidatorFactory;
 	}
@@ -207,7 +207,7 @@ public final class ReactiveOidcIdTokenDecoderFactory implements ReactiveJwtDecod
 	 * @param jwsAlgorithmResolver the resolver that provides the expected {@link JwsAlgorithm JWS algorithm}
 	 *                             for a specific {@link ClientRegistration client}
 	 */
-	public final void setJwsAlgorithmResolver(Function<ClientRegistration, JwsAlgorithm> jwsAlgorithmResolver) {
+	public void setJwsAlgorithmResolver(Function<ClientRegistration, JwsAlgorithm> jwsAlgorithmResolver) {
 		Assert.notNull(jwsAlgorithmResolver, "jwsAlgorithmResolver cannot be null");
 		this.jwsAlgorithmResolver = jwsAlgorithmResolver;
 	}
@@ -219,7 +219,7 @@ public final class ReactiveOidcIdTokenDecoderFactory implements ReactiveJwtDecod
 	 * @param claimTypeConverterFactory the factory that provides a {@link Converter} used for type conversion
 	 *                                  of claim values for a specific {@link ClientRegistration client}
 	 */
-	public final void setClaimTypeConverterFactory(Function<ClientRegistration, Converter<Map<String, Object>, Map<String, Object>>> claimTypeConverterFactory) {
+	public void setClaimTypeConverterFactory(Function<ClientRegistration, Converter<Map<String, Object>, Map<String, Object>>> claimTypeConverterFactory) {
 		Assert.notNull(claimTypeConverterFactory, "claimTypeConverterFactory cannot be null");
 		this.claimTypeConverterFactory = claimTypeConverterFactory;
 	}

+ 1 - 1
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/AuthenticatedPrincipalOAuth2AuthorizedClientRepository.java

@@ -61,7 +61,7 @@ public final class AuthenticatedPrincipalOAuth2AuthorizedClientRepository implem
 	 *
 	 * @param anonymousAuthorizedClientRepository the repository used for requests that are unauthenticated (or anonymous)
 	 */
-	public final void setAnonymousAuthorizedClientRepository(OAuth2AuthorizedClientRepository anonymousAuthorizedClientRepository) {
+	public void setAnonymousAuthorizedClientRepository(OAuth2AuthorizedClientRepository anonymousAuthorizedClientRepository) {
 		Assert.notNull(anonymousAuthorizedClientRepository, "anonymousAuthorizedClientRepository cannot be null");
 		this.anonymousAuthorizedClientRepository = anonymousAuthorizedClientRepository;
 	}

+ 1 - 1
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java

@@ -177,7 +177,7 @@ public final class OAuth2AuthorizedClientArgumentResolver implements HandlerMeth
 	 * @param clientCredentialsTokenResponseClient the client used when requesting an access token credential at the Token Endpoint for the {@code client_credentials} grant
 	 */
 	@Deprecated
-	public final void setClientCredentialsTokenResponseClient(
+	public void setClientCredentialsTokenResponseClient(
 			OAuth2AccessTokenResponseClient<OAuth2ClientCredentialsGrantRequest> clientCredentialsTokenResponseClient) {
 		Assert.notNull(clientCredentialsTokenResponseClient, "clientCredentialsTokenResponseClient cannot be null");
 		Assert.state(this.defaultAuthorizedClientManager, "The client cannot be set when the constructor used is \"OAuth2AuthorizedClientArgumentResolver(OAuth2AuthorizedClientManager)\". " +

+ 2 - 2
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/function/client/OAuth2AuthorizedClientResolver.java

@@ -57,7 +57,7 @@ class OAuth2AuthorizedClientResolver {
 
 	private String defaultClientRegistrationId;
 
-	public OAuth2AuthorizedClientResolver(
+	OAuth2AuthorizedClientResolver(
 			ReactiveClientRegistrationRepository clientRegistrationRepository,
 			ServerOAuth2AuthorizedClientRepository authorizedClientRepository) {
 		Assert.notNull(clientRegistrationRepository, "clientRegistrationRepository cannot be null");
@@ -175,7 +175,7 @@ class OAuth2AuthorizedClientResolver {
 		private final Authentication authentication;
 		private final ServerWebExchange exchange;
 
-		public Request(String clientRegistrationId, Authentication authentication,
+		Request(String clientRegistrationId, Authentication authentication,
 				ServerWebExchange exchange) {
 			this.clientRegistrationId = clientRegistrationId;
 			this.authentication = authentication;

+ 2 - 2
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/result/method/annotation/OAuth2AuthorizedClientResolver.java

@@ -57,7 +57,7 @@ class OAuth2AuthorizedClientResolver {
 
 	private String defaultClientRegistrationId;
 
-	public OAuth2AuthorizedClientResolver(
+	OAuth2AuthorizedClientResolver(
 			ReactiveClientRegistrationRepository clientRegistrationRepository,
 			ServerOAuth2AuthorizedClientRepository authorizedClientRepository) {
 		Assert.notNull(clientRegistrationRepository, "clientRegistrationRepository cannot be null");
@@ -176,7 +176,7 @@ class OAuth2AuthorizedClientResolver {
 		private final Authentication authentication;
 		private final ServerWebExchange exchange;
 
-		public Request(String clientRegistrationId, Authentication authentication,
+		Request(String clientRegistrationId, Authentication authentication,
 				ServerWebExchange exchange) {
 			this.clientRegistrationId = clientRegistrationId;
 			this.authentication = authentication;

+ 1 - 1
oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/server/AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository.java

@@ -65,7 +65,7 @@ public final class AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository
 	 *
 	 * @param anonymousAuthorizedClientRepository the repository used for requests that are unauthenticated (or anonymous)
 	 */
-	public final void setAnonymousAuthorizedClientRepository(
+	public void setAnonymousAuthorizedClientRepository(
 			ServerOAuth2AuthorizedClientRepository anonymousAuthorizedClientRepository) {
 		Assert.notNull(anonymousAuthorizedClientRepository, "anonymousAuthorizedClientRepository cannot be null");
 		this.anonymousAuthorizedClientRepository = anonymousAuthorizedClientRepository;

+ 2 - 2
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoderJwkSupport.java

@@ -108,7 +108,7 @@ public final class NimbusJwtDecoderJwkSupport implements JwtDecoder {
 	 *
 	 * @param claimSetConverter the {@link Converter} to use
 	 */
-	public final void setClaimSetConverter(Converter<Map<String, Object>, Map<String, Object>> claimSetConverter) {
+	public void setClaimSetConverter(Converter<Map<String, Object>, Map<String, Object>> claimSetConverter) {
 		Assert.notNull(claimSetConverter, "claimSetConverter cannot be null");
 		this.claimSetConverter = claimSetConverter;
 		this.delegate.setClaimSetConverter(claimSetConverter);
@@ -120,7 +120,7 @@ public final class NimbusJwtDecoderJwkSupport implements JwtDecoder {
 	 * @since 5.1
 	 * @param restOperations the {@link RestOperations} used when requesting the JSON Web Key (JWK) Set
 	 */
-	public final void setRestOperations(RestOperations restOperations) {
+	public void setRestOperations(RestOperations restOperations) {
 		Assert.notNull(restOperations, "restOperations cannot be null");
 		this.jwtDecoderBuilder = this.jwtDecoderBuilder.restOperations(restOperations);
 		this.delegate = makeDelegate();

+ 1 - 1
oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationEntryPoint.java

@@ -107,7 +107,7 @@ public final class BearerTokenAuthenticationEntryPoint implements Authentication
 	 *
 	 * @param realmName
 	 */
-	public final void setRealmName(String realmName) {
+	public void setRealmName(String realmName) {
 		this.realmName = realmName;
 	}
 

+ 3 - 3
oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationFilter.java

@@ -143,7 +143,7 @@ public final class BearerTokenAuthenticationFilter extends OncePerRequestFilter
 	 * Set the {@link BearerTokenResolver} to use. Defaults to {@link DefaultBearerTokenResolver}.
 	 * @param bearerTokenResolver the {@code BearerTokenResolver} to use
 	 */
-	public final void setBearerTokenResolver(BearerTokenResolver bearerTokenResolver) {
+	public void setBearerTokenResolver(BearerTokenResolver bearerTokenResolver) {
 		Assert.notNull(bearerTokenResolver, "bearerTokenResolver cannot be null");
 		this.bearerTokenResolver = bearerTokenResolver;
 	}
@@ -152,7 +152,7 @@ public final class BearerTokenAuthenticationFilter extends OncePerRequestFilter
 	 * Set the {@link AuthenticationEntryPoint} to use. Defaults to {@link BearerTokenAuthenticationEntryPoint}.
 	 * @param authenticationEntryPoint the {@code AuthenticationEntryPoint} to use
 	 */
-	public final void setAuthenticationEntryPoint(final AuthenticationEntryPoint authenticationEntryPoint) {
+	public void setAuthenticationEntryPoint(final AuthenticationEntryPoint authenticationEntryPoint) {
 		Assert.notNull(authenticationEntryPoint, "authenticationEntryPoint cannot be null");
 		this.authenticationEntryPoint = authenticationEntryPoint;
 	}
@@ -162,7 +162,7 @@ public final class BearerTokenAuthenticationFilter extends OncePerRequestFilter
 	 * @param authenticationFailureHandler the {@code AuthenticationFailureHandler} to use
 	 * @since 5.2
 	 */
-	public final void setAuthenticationFailureHandler(final AuthenticationFailureHandler authenticationFailureHandler) {
+	public void setAuthenticationFailureHandler(final AuthenticationFailureHandler authenticationFailureHandler) {
 		Assert.notNull(authenticationFailureHandler, "authenticationFailureHandler cannot be null");
 		this.authenticationFailureHandler = authenticationFailureHandler;
 	}

+ 1 - 1
oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandler.java

@@ -85,7 +85,7 @@ public final class BearerTokenAccessDeniedHandler implements AccessDeniedHandler
 	 *
 	 * @param realmName
 	 */
-	public final void setRealmName(String realmName) {
+	public void setRealmName(String realmName) {
 		this.realmName = realmName;
 	}
 

+ 1 - 1
oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandlerTests.java

@@ -117,7 +117,7 @@ public class BearerTokenAccessDeniedHandlerTests {
 		}
 
 		static class TestingOAuth2Token extends AbstractOAuth2Token {
-			public TestingOAuth2Token(String tokenValue) {
+			TestingOAuth2Token(String tokenValue) {
 				super(tokenValue);
 			}
 		}

+ 1 - 1
oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/server/BearerTokenServerAccessDeniedHandlerTests.java

@@ -114,7 +114,7 @@ public class BearerTokenServerAccessDeniedHandlerTests {
 		}
 
 		static class TestingOAuth2Token extends AbstractOAuth2Token {
-			public TestingOAuth2Token(String tokenValue) {
+			TestingOAuth2Token(String tokenValue) {
 				super(tokenValue);
 			}
 		}

+ 1 - 1
remoting/src/test/java/org/springframework/security/remoting/httpinvoker/AuthenticationSimpleHttpInvokerRequestExecutorTests.java

@@ -105,7 +105,7 @@ public class AuthenticationSimpleHttpInvokerRequestExecutorTests {
 
 		private Map<String, String> requestProperties = new HashMap<>();
 
-		public MockHttpURLConnection(URL u) {
+		MockHttpURLConnection(URL u) {
 			super(u);
 		}
 

+ 2 - 2
samples/boot/oauth2authorizationserver/src/main/java/sample/AuthorizationServerConfiguration.java

@@ -191,7 +191,7 @@ class UserConfig extends WebSecurityConfigurerAdapter {
 class IntrospectEndpoint {
 	TokenStore tokenStore;
 
-	public IntrospectEndpoint(TokenStore tokenStore) {
+	IntrospectEndpoint(TokenStore tokenStore) {
 		this.tokenStore = tokenStore;
 	}
 
@@ -226,7 +226,7 @@ class IntrospectEndpoint {
 class JwkSetEndpoint {
 	KeyPair keyPair;
 
-	public JwkSetEndpoint(KeyPair keyPair) {
+	JwkSetEndpoint(KeyPair keyPair) {
 		this.keyPair = keyPair;
 	}
 

+ 1 - 1
samples/boot/oauth2resourceserver-jwe/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java

@@ -84,7 +84,7 @@ public class OAuth2ResourceServerApplicationITests {
 	private static class BearerTokenRequestPostProcessor implements RequestPostProcessor {
 		private String token;
 
-		public BearerTokenRequestPostProcessor(String token) {
+		BearerTokenRequestPostProcessor(String token) {
 			this.token = token;
 		}
 

+ 1 - 1
samples/boot/oauth2resourceserver-multitenancy/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java

@@ -132,7 +132,7 @@ public class OAuth2ResourceServerApplicationITests {
 	private static class BearerTokenRequestPostProcessor implements RequestPostProcessor {
 		private String token;
 
-		public BearerTokenRequestPostProcessor(String token) {
+		BearerTokenRequestPostProcessor(String token) {
 			this.token = token;
 		}
 

+ 1 - 1
samples/boot/oauth2resourceserver-opaque/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java

@@ -84,7 +84,7 @@ public class OAuth2ResourceServerApplicationITests {
 	private static class BearerTokenRequestPostProcessor implements RequestPostProcessor {
 		private String token;
 
-		public BearerTokenRequestPostProcessor(String token) {
+		BearerTokenRequestPostProcessor(String token) {
 			this.token = token;
 		}
 

+ 1 - 1
samples/boot/oauth2resourceserver-static/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java

@@ -84,7 +84,7 @@ public class OAuth2ResourceServerApplicationITests {
 	private static class BearerTokenRequestPostProcessor implements RequestPostProcessor {
 		private String token;
 
-		public BearerTokenRequestPostProcessor(String token) {
+		BearerTokenRequestPostProcessor(String token) {
 			this.token = token;
 		}
 

+ 1 - 1
samples/boot/oauth2resourceserver/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java

@@ -107,7 +107,7 @@ public class OAuth2ResourceServerApplicationITests {
 	private static class BearerTokenRequestPostProcessor implements RequestPostProcessor {
 		private String token;
 
-		public BearerTokenRequestPostProcessor(String token) {
+		BearerTokenRequestPostProcessor(String token) {
 			this.token = token;
 		}
 

+ 1 - 1
samples/xml/jaas/src/main/java/samples/jaas/UsernameEqualsPasswordLoginModule.java

@@ -94,7 +94,7 @@ public class UsernameEqualsPasswordLoginModule implements LoginModule {
 	private static class UsernamePrincipal implements Principal, Serializable {
 		private final String username;
 
-		public UsernamePrincipal(String username) {
+		UsernamePrincipal(String username) {
 			this.username = username;
 		}
 

+ 1 - 1
test/src/main/java/org/springframework/security/test/context/support/DelegatingTestExecutionListener.java

@@ -30,7 +30,7 @@ class DelegatingTestExecutionListener
 
 	private final TestExecutionListener delegate;
 
-	public DelegatingTestExecutionListener(TestExecutionListener delegate) {
+	DelegatingTestExecutionListener(TestExecutionListener delegate) {
 		Assert.notNull(delegate, "delegate cannot be null");
 		this.delegate = delegate;
 	}

+ 1 - 1
test/src/main/java/org/springframework/security/test/context/support/WithUserDetailsSecurityContextFactory.java

@@ -49,7 +49,7 @@ final class WithUserDetailsSecurityContextFactory implements
 	private BeanFactory beans;
 
 	@Autowired
-	public WithUserDetailsSecurityContextFactory(BeanFactory beans) {
+	WithUserDetailsSecurityContextFactory(BeanFactory beans) {
 		this.beans = beans;
 	}
 

+ 1 - 1
test/src/main/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessors.java

@@ -826,7 +826,7 @@ public final class SecurityMockMvcRequestPostProcessors {
 			implements RequestPostProcessor {
 		private final RequestPostProcessor delegate;
 
-		public UserDetailsRequestPostProcessor(UserDetails user) {
+		UserDetailsRequestPostProcessor(UserDetails user) {
 			Authentication token = new UsernamePasswordAuthenticationToken(user,
 					user.getPassword(), user.getAuthorities());
 

+ 1 - 1
test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsCsrfTests.java

@@ -205,7 +205,7 @@ public class SecurityMockMvcRequestPostProcessorsCsrfTests {
 		static class SessionRequestWrapper extends HttpServletRequestWrapper {
 			HttpSession session = new MockHttpSession();
 
-			public SessionRequestWrapper(HttpServletRequest request) {
+			SessionRequestWrapper(HttpServletRequest request) {
 				super(request);
 			}
 

+ 1 - 1
web/src/main/java/org/springframework/security/web/FilterInvocation.java

@@ -158,7 +158,7 @@ class DummyRequest extends HttpServletRequestWrapper {
 	private String queryString;
 	private String method;
 
-	public DummyRequest() {
+	DummyRequest() {
 		super(UNSUPPORTED_REQUEST);
 	}
 

+ 1 - 1
web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java

@@ -38,7 +38,7 @@ import org.springframework.expression.TypedValue;
 class DelegatingEvaluationContext implements EvaluationContext {
 	private final EvaluationContext delegate;
 
-	public DelegatingEvaluationContext(EvaluationContext delegate) {
+	DelegatingEvaluationContext(EvaluationContext delegate) {
 		this.delegate = delegate;
 	}
 

+ 2 - 2
web/src/main/java/org/springframework/security/web/access/expression/ExpressionBasedFilterInvocationSecurityMetadataSource.java

@@ -99,7 +99,7 @@ public final class ExpressionBasedFilterInvocationSecurityMetadataSource
 			extends AbstractVariableEvaluationContextPostProcessor {
 		private final AntPathRequestMatcher matcher;
 
-		public AntPathMatcherEvaluationContextPostProcessor(
+		AntPathMatcherEvaluationContextPostProcessor(
 				AntPathRequestMatcher matcher) {
 			this.matcher = matcher;
 		}
@@ -114,7 +114,7 @@ public final class ExpressionBasedFilterInvocationSecurityMetadataSource
 			extends AbstractVariableEvaluationContextPostProcessor {
 		private final RequestMatcher matcher;
 
-		public RequestVariablesExtractorEvaluationContextPostProcessor(
+		RequestVariablesExtractorEvaluationContextPostProcessor(
 				RequestMatcher matcher) {
 			this.matcher = matcher;
 		}

+ 1 - 1
web/src/main/java/org/springframework/security/web/access/expression/WebExpressionConfigAttribute.java

@@ -31,7 +31,7 @@ class WebExpressionConfigAttribute implements ConfigAttribute,
 	private final Expression authorizeExpression;
 	private final EvaluationContextPostProcessor<FilterInvocation> postProcessor;
 
-	public WebExpressionConfigAttribute(Expression authorizeExpression,
+	WebExpressionConfigAttribute(Expression authorizeExpression,
 			EvaluationContextPostProcessor<FilterInvocation> postProcessor) {
 		this.authorizeExpression = authorizeExpression;
 		this.postProcessor = postProcessor;

+ 2 - 2
web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/DefaultWASUsernameAndGroupsExtractor.java

@@ -58,11 +58,11 @@ final class DefaultWASUsernameAndGroupsExtractor implements WASUsernameAndGroups
 	// SEC-803
 	private static Class<?> wsCredentialClass = null;
 
-	public final List<String> getGroupsForCurrentUser() {
+	public List<String> getGroupsForCurrentUser() {
 		return getWebSphereGroups(getRunAsSubject());
 	}
 
-	public final String getCurrentUserName() {
+	public String getCurrentUserName() {
 		return getSecurityName(getRunAsSubject());
 	}
 

Beberapa file tidak ditampilkan karena terlalu banyak file yang berubah dalam diff ini